Backport #4370: fix(vite): rebuild workflows once per change, not per environment - #4385
Merged
Merged
Conversation
) Vite calls hotUpdate once per environment (client, ssr, and any a framework adds, such as Nitro's) for each file change. The plugin rebuilt every workflow on each call, so a single edit cost two to three full rebuilds, run back to back before Vite sent any HMR update. Remember each change by (timestamp, file), which Vite shares across a change's environment calls, and skip the repeats. Signed-off-by: Alex Langenfeld <alex.langenfeld@vercel.com>
🦋 Changeset detectedLatest commit: d8eeaa0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Contributor
Author
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (106 failed)redis (21 failed):
turso (85 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
|
VaguelySerious
approved these changes
Sep 30, 2026
The backport carried main's jsdom@26.1.0(supports-color@10.2.2) peer suffix, which has no snapshot on stable, so frozen installs failed with ERR_PNPM_LOCKFILE_MISSING_DEPENDENCY. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated backport of #4370 to
stable(backport job run).AI recommendation: This is a bug fix to
workflowHotUpdatePlugin, which exists onstable(verifiedpackages/vite/src/hot-update.tsis present there without the dedup logic), where Vite's per-environmenthotUpdatecalls triggered 2-3 full workflow rebuilds per file change, stalling HMR and making dev/e2e tests flaky. It carries apatchchangeset, adds no new API surface or options, and the only other changes are a test file plus thetestscript/vitestdevDependency needed to run it — test and build plumbing rather than feature work.Merge conflicts were resolved by AI (opencode with
anthropic/claude-opus-5). Please review the conflict resolution carefully before merging.