Backport #4408: fix(core): start() with an explicit deploymentId outside a deployment - #4425
Merged
Merged
Conversation
…#4408) recreateRunFromExisting (Replay Run) from a process that is not itself a deployment failed because start() called world.getDeploymentId() unconditionally. With a concrete target, an unavailable current deployment now means a cross-deployment start instead of an error. Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Pranay Prakash <pranay.gp@gmail.com>
🦋 Changeset detectedLatest commit: 4b8d404 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pranaygp
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated backport of #4408 to
stable(backport job run).AI recommendation: This is a patch-level bug fix to
start()in@workflow/core, which exists onstablewith the same defect:packages/core/src/runtime/start.tsonstablealso callsworld.getDeploymentId()unconditionally (line 178) before honoringopts.deploymentId, so Replay Run /recreateRunFromExistingfails from any process that is not itself a deployment. The cross-deployment start path it falls back to already exists onstable, and the change adds no new API surface — behavior is unchanged when the current deployment is available, and the accompanying tests cover existing behavior.Merge conflicts were resolved by AI (opencode with
anthropic/claude-opus-5). Please review the conflict resolution carefully before merging.