Skip to content

Backport #4421: fix(core): don't strand runs on throttled writes past the delivery ceiling or in QuickJS inline claims - #4437

Closed
github-actions[bot] wants to merge 1 commit into
stablefrom
backport/pr-4421-to-stable
Closed

github-actions[bot] wants to merge 1 commit into
stablefrom
backport/pr-4421-to-stable

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated backport of #4421 to stable (backport job run).

AI recommendation: Both halves are stability fixes, not feature work: the run stranded running with no queue message left to drive it after a transient (429/5xx/transport) failure of the max-deliveries run_failed write. That give-up path exists verbatim on stable (packages/core/src/runtime.ts around the "Failed to mark run as failed after ... delivery attempts" log, with isRetryableWorldError already imported), so the runtime.ts fix and its runtime.test.ts coverage apply directly. The QuickJS half (packages/core/src/runtime/quickjs-entrypoint.ts and its new test) is main-only — that file is absent on stable — so those hunks should simply be dropped during the cherry-pick along with their changeset.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-5). Please review the conflict resolution carefully before merging.

…iling or in QuickJS inline claims (#4421)

* fix(core): don't strand a run on throttled writes past the delivery ceiling or in QuickJS inline claims

* fix(core): gate throttled-step stepInput on the CBOR queue transport

* fix(core): defer a replay for a throttled QuickJS inline step, like the node engine

Signed-off-by: Nathan Rajlich <n@n8.io>
@changeset-bot

changeset-bot Bot commented Sep 25, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f3cea21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@workflow/core Patch
@workflow/builders Patch
@workflow/cli Patch
@workflow/next Patch
@workflow/nitro Patch
@workflow/vitest Patch
@workflow/web-shared Patch
@workflow/web Patch
workflow Patch
@workflow/world-testing Patch
@workflow/astro Patch
@workflow/nest Patch
@workflow/rollup Patch
@workflow/sveltekit Patch
@workflow/vite Patch
@workflow/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
example-nextjs-workflow-turbopack Ready Ready Preview, v0 Sep 25, 2026 9:15pm UTC
example-nextjs-workflow-webpack Ready Ready Preview, v0 Sep 25, 2026 9:15pm UTC
example-workflow Ready Ready Preview, v0 Sep 25, 2026 9:15pm UTC
workbench-astro-workflow Ready Ready Preview, v0 Sep 25, 2026 9:15pm UTC
workbench-express-workflow Ready Ready Preview, v0 Sep 25, 2026 9:15pm UTC
workbench-fastify-workflow Ready Ready Preview, v0 Sep 25, 2026 9:15pm UTC
workbench-hono-workflow Ready Ready Preview, v0 Sep 25, 2026 9:15pm UTC
workbench-nestjs-workflow Ready Ready Preview, v0 Sep 25, 2026 9:15pm UTC
workbench-nitro-workflow Ready Ready Preview, v0 Sep 25, 2026 9:15pm UTC
workbench-nuxt-workflow Ready Ready Preview, v0 Sep 25, 2026 9:15pm UTC
workbench-python-workflow Error Error v0 Sep 25, 2026 9:15pm UTC
workbench-sveltekit-workflow Ready Ready Preview, v0 Sep 25, 2026 9:15pm UTC
workbench-tanstack-start-workflow Ready Ready Preview, v0 Sep 25, 2026 9:15pm UTC
workbench-vite-workflow Ready Ready Preview, v0 Sep 25, 2026 9:15pm UTC
workflow-docs Ready Ready Preview, v0 Sep 25, 2026 9:15pm UTC
workflow-swc-playground Ready Ready Preview, v0 Sep 25, 2026 9:15pm UTC
workflow-tarballs Ready Ready Preview, v0 Sep 25, 2026 9:15pm UTC
workflow-web Ready Ready Preview, v0 Sep 25, 2026 9:15pm UTC

Copy link
Copy Markdown
Member

Closing as superseded by #4422, which targets stable directly and already contains this same runtime.ts change (throw on isRetryableWorldError for the max-deliveries run_failed write), plus the v4 step-handler.ts fix. Both PRs add the same changeset file and edit the same hunk, so they'd conflict. Note: stable's world-postgres caps jobs at 3 attempts, so the comment here about world-postgres/#4428 doesn't apply on stable. The one extra test here ("acks when the run already reached a terminal state") could be ported to #4422.

@TooTallNate
TooTallNate deleted the backport/pr-4421-to-stable branch September 28, 2026 18:53

This branch was successfully deployed

1 active deployment
Preview – workflow-docs — f3cea21d Deployed Sep 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant