Skip to content

fix(world-local): converge hook owner publication with claim adopters - #4636

Merged
alangenfeld merged 1 commit into
mainfrom
alangenfeld/workflow-ci-health-investigation
Oct 5, 2026
Merged

alangenfeld merged 1 commit into
mainfrom
alangenfeld/workflow-ci-health-investigation

Conversation

@alangenfeld

Copy link
Copy Markdown
Collaborator

Summary & Motivation

Concurrent storage instances can append duplicate hook_created events when a retry publishes the claimed event slot before the original claim owner, which only rejects later at the entity write. Converges the owner onto the adopter's published event for the same hook before bumping, so an unrelated slot collision still bumps normally.

Test Plan

Adds a deterministic test that fails against unmodified main (two creation events) and passes with the fix; 20 targeted tests across hook-create-publication, hook-staging-slots, and slot-identity pass, along with existing same-hook cross-instance and legacy cases. No full suite run locally; CI pending.

Signed-off-by: Alex Langenfeld <alex.langenfeld@vercel.com>
@changeset-bot

changeset-bot Bot commented Oct 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a166e18

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@workflow/world-local Patch
@workflow/cli Patch
@workflow/core Patch
@workflow/vitest Patch
@workflow/web Patch
@workflow/world-postgres Patch
workflow Patch
@workflow/world-testing Patch
@workflow/builders Patch
@workflow/next Patch
@workflow/nitro Patch
@workflow/web-shared Patch
@workflow/astro Patch
@workflow/nest Patch
@workflow/rollup Patch
@workflow/sveltekit Patch
@workflow/vite Patch
@workflow/nuxt Patch
@workflow/world-vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
example-nextjs-workflow-turbopack Ready Ready Preview, v0 Oct 5, 2026 4:57pm UTC
example-nextjs-workflow-webpack Ready Ready Preview, v0 Oct 5, 2026 4:57pm UTC
example-workflow Ready Ready Preview, v0 Oct 5, 2026 4:57pm UTC
workbench-astro-workflow Ready Ready Preview, v0 Oct 5, 2026 4:57pm UTC
workbench-express-workflow Ready Ready Preview, v0 Oct 5, 2026 4:57pm UTC
workbench-fastify-workflow Ready Ready Preview, v0 Oct 5, 2026 4:57pm UTC
workbench-hono-workflow Ready Ready Preview, v0 Oct 5, 2026 4:57pm UTC
workbench-nestjs-workflow Ready Ready Preview, v0 Oct 5, 2026 4:57pm UTC
workbench-nitro-workflow Ready Ready Preview, v0 Oct 5, 2026 4:57pm UTC
workbench-nuxt-workflow Ready Ready Preview, v0 Oct 5, 2026 4:57pm UTC
workbench-python-workflow Ready Ready Preview, v0 Oct 5, 2026 4:57pm UTC
workbench-sveltekit-workflow Ready Ready Preview, v0 Oct 5, 2026 4:57pm UTC
workbench-tanstack-start-workflow Ready Ready Preview, v0 Oct 5, 2026 4:57pm UTC
workbench-vite-workflow Ready Ready Preview, v0 Oct 5, 2026 4:57pm UTC
workflow-docs Ready Ready Preview, v0 Oct 5, 2026 4:57pm UTC
workflow-swc-playground Ready Ready Preview, v0 Oct 5, 2026 4:57pm UTC
workflow-tarballs Ready Ready Preview, v0 Oct 5, 2026 4:57pm UTC
workflow-web Ready Ready Preview, v0 Oct 5, 2026 4:57pm UTC

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

✅ All tests passed

⚠️ Flaky E2E Tests (passed on retry)

These tests failed at least once and passed on a retry. A recurring entry here is a real race worth investigating.

  • readableStreamWorkflow (vite · vercel-prod / vercel / node / production)
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step (nuxt · local-dev / local / node / stable)
  • stream-level prepareStep overrides constructor-level (sveltekit · vercel-prod / vercel / node / production)

🛠 Infra Events (absorbed by the harness)

Platform anomalies the e2e harness detected and worked around (e.g. a run the queue never picked up, replaced by a fresh run). Clustered timestamps indicate a backend blip; a steady drip indicates a platform issue worth escalating.

  • run-pickup-stall · runs app-generated source against a registered step (tanstack-start) · at 16:57:17Z · abandoned wrun_01M46FYN3J5KTVKC8X9G4M23NS
  • cold-start-warmup · suite warmup (tanstack-start) · at 16:57:24Z · abandoned wrun_01M46FYN3VZ9T5W7K9E1SKC3H4
  • run-pickup-stall · hookCleanupTestWorkflow - hook token reuse after workflow completion (nextjs-webpack) · at 17:03:42Z · abandoned wrun_01M46GAD19YC4G1XYTYD1V0SSW

E2E Test Summary

Summary
Passed Failed Skipped Total
✅ ▲ Vercel Production 3904 0 875 4779
✅ 💻 Local Development 4582 0 551 5133
✅ 📦 Local Production 4582 0 551 5133
✅ 🐘 Local Postgres 4582 0 551 5133
✅ 🪟 Windows 342 0 12 354
✅ 🌐 Cross-language Conformance 68 0 84 152
✅ dynamic-runs 0 0 0 0
✅ vercel-http-transport 879 0 183 1062
✅ vercel-multi-region 27 0 0 27
✅ vercel-ws-transport 595 0 113 708
Total 19561 0 2920 22481
Details by Category

✅ ▲ Vercel Production

App Passed Failed Skipped
✅ astro-node 142 0 35
✅ astro-quickjs 142 0 35
✅ example-node 142 0 35
✅ example-quickjs 142 0 35
✅ express-node 142 0 35
✅ express-quickjs 142 0 35
✅ fastify-node 142 0 35
✅ fastify-quickjs 142 0 35
✅ hono-node 142 0 35
✅ hono-quickjs 142 0 35
✅ nest-node 142 0 35
✅ nest-quickjs 142 0 35
✅ nextjs-turbopack-node 169 0 8
✅ nextjs-turbopack-quickjs 169 0 8
✅ nextjs-webpack-node 169 0 8
✅ nextjs-webpack-quickjs 169 0 8
✅ nitro-node 142 0 35
✅ nitro-quickjs 142 0 35
✅ nuxt-node 142 0 35
✅ nuxt-quickjs 142 0 35
✅ python-node 66 0 111
✅ sveltekit-node 161 0 16
✅ sveltekit-quickjs 161 0 16
✅ tanstack-start-node 142 0 35
✅ tanstack-start-quickjs 142 0 35
✅ vite-node 142 0 35
✅ vite-quickjs 142 0 35

✅ 💻 Local Development

App Passed Failed Skipped
✅ astro-stable-node 148 0 29
✅ astro-stable-quickjs 148 0 29
✅ express-stable-node 148 0 29
✅ express-stable-quickjs 148 0 29
✅ fastify-stable-node 148 0 29
✅ fastify-stable-quickjs 148 0 29
✅ hono-stable-node 148 0 29
✅ hono-stable-quickjs 148 0 29
✅ nest-stable-node 148 0 29
✅ nest-stable-quickjs 148 0 29
✅ nextjs-turbopack-canary-node 176 0 1
✅ nextjs-turbopack-canary-quickjs 176 0 1
✅ nextjs-turbopack-quickjs-snapshot 176 0 1
✅ nextjs-turbopack-stable-node 176 0 1
✅ nextjs-turbopack-stable-quickjs 176 0 1
✅ nextjs-webpack-canary-node 176 0 1
✅ nextjs-webpack-canary-quickjs 176 0 1
✅ nextjs-webpack-stable-node 176 0 1
✅ nextjs-webpack-stable-quickjs 176 0 1
✅ nitro-stable-node 148 0 29
✅ nitro-stable-quickjs 148 0 29
✅ nuxt-stable-node 148 0 29
✅ nuxt-stable-quickjs 148 0 29
✅ sveltekit-stable-node 167 0 10
✅ sveltekit-stable-quickjs 167 0 10
✅ tanstack-start-node 148 0 29
✅ tanstack-start-quickjs 148 0 29
✅ vite-stable-node 148 0 29
✅ vite-stable-quickjs 148 0 29

✅ 📦 Local Production

App Passed Failed Skipped
✅ astro-stable-node 148 0 29
✅ astro-stable-quickjs 148 0 29
✅ express-stable-node 148 0 29
✅ express-stable-quickjs 148 0 29
✅ fastify-stable-node 148 0 29
✅ fastify-stable-quickjs 148 0 29
✅ hono-stable-node 148 0 29
✅ hono-stable-quickjs 148 0 29
✅ nest-stable-node 148 0 29
✅ nest-stable-quickjs 148 0 29
✅ nextjs-turbopack-canary-node 176 0 1
✅ nextjs-turbopack-canary-quickjs 176 0 1
✅ nextjs-turbopack-quickjs-snapshot 176 0 1
✅ nextjs-turbopack-stable-node 176 0 1
✅ nextjs-turbopack-stable-quickjs 176 0 1
✅ nextjs-webpack-canary-node 176 0 1
✅ nextjs-webpack-canary-quickjs 176 0 1
✅ nextjs-webpack-stable-node 176 0 1
✅ nextjs-webpack-stable-quickjs 176 0 1
✅ nitro-stable-node 148 0 29
✅ nitro-stable-quickjs 148 0 29
✅ nuxt-stable-node 148 0 29
✅ nuxt-stable-quickjs 148 0 29
✅ sveltekit-stable-node 167 0 10
✅ sveltekit-stable-quickjs 167 0 10
✅ tanstack-start-node 148 0 29
✅ tanstack-start-quickjs 148 0 29
✅ vite-stable-node 148 0 29
✅ vite-stable-quickjs 148 0 29

✅ 🐘 Local Postgres

App Passed Failed Skipped
✅ astro-stable-node 148 0 29
✅ astro-stable-quickjs 148 0 29
✅ express-stable-node 148 0 29
✅ express-stable-quickjs 148 0 29
✅ fastify-stable-node 148 0 29
✅ fastify-stable-quickjs 148 0 29
✅ hono-stable-node 148 0 29
✅ hono-stable-quickjs 148 0 29
✅ nest-stable-node 148 0 29
✅ nest-stable-quickjs 148 0 29
✅ nextjs-turbopack-canary-node 176 0 1
✅ nextjs-turbopack-canary-quickjs 176 0 1
✅ nextjs-turbopack-quickjs-snapshot 176 0 1
✅ nextjs-turbopack-stable-node 176 0 1
✅ nextjs-turbopack-stable-quickjs 176 0 1
✅ nextjs-webpack-canary-node 176 0 1
✅ nextjs-webpack-canary-quickjs 176 0 1
✅ nextjs-webpack-stable-node 176 0 1
✅ nextjs-webpack-stable-quickjs 176 0 1
✅ nitro-stable-node 148 0 29
✅ nitro-stable-quickjs 148 0 29
✅ nuxt-stable-node 148 0 29
✅ nuxt-stable-quickjs 148 0 29
✅ sveltekit-stable-node 167 0 10
✅ sveltekit-stable-quickjs 167 0 10
✅ tanstack-start-node 148 0 29
✅ tanstack-start-quickjs 148 0 29
✅ vite-stable-node 148 0 29
✅ vite-stable-quickjs 148 0 29

✅ 🪟 Windows

App Passed Failed Skipped
✅ nextjs-turbopack-node 171 0 6
✅ nextjs-turbopack-quickjs 171 0 6

✅ 🌐 Cross-language Conformance

App Passed Failed Skipped
✅ python 68 0 84

✅ dynamic-runs

App Passed Failed Skipped
✅ astro-vercel 0 0 0
✅ example-vercel 0 0 0
✅ express-vercel 0 0 0
✅ fastify-vercel 0 0 0
✅ hono-vercel 0 0 0
✅ nest-vercel 0 0 0
✅ nextjs-turbopack-vercel 0 0 0
✅ nextjs-webpack-vercel 0 0 0
✅ nitro-vercel 0 0 0
✅ nuxt-vercel 0 0 0
✅ sveltekit-vercel 0 0 0
✅ tanstack-start-vercel 0 0 0
✅ vite-vercel 0 0 0

✅ vercel-http-transport

App Passed Failed Skipped
✅ example 142 0 35
✅ express 142 0 35
✅ hono 142 0 35
✅ nextjs-turbopack 169 0 8
✅ nitro 142 0 35
✅ vite 142 0 35

✅ vercel-multi-region

App Passed Failed Skipped
✅ nextjs-turbopack 27 0 0

✅ vercel-ws-transport

App Passed Failed Skipped
✅ example 142 0 35
✅ express 142 0 35
✅ nextjs-turbopack 169 0 8
✅ vite 142 0 35

📋 View full workflow run

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit a166e18 · Mon, 05 Oct 2026 17:11:43 GMT · run logs

Backend: vercel · app: nextjs-turbopack

Metric Scenario Best (ms) P75 (ms) P90 (ms) P99 (ms) Samples
TTFS step 2145 (+194%) 🔻 2310 🔴 (+112%) 🔻 2387 🔴 (+114%) 🔻 2681 🔴 (+123%) 🔻 30
TTFS stream 2144 (+875%) 🔻 2223 🔴 (+112%) 🔻 2232 🔴 (+103%) 🔻 2413 🔴 (+69%) 🔻 30
TTFS hook + stream 586 (-33%) 💚 2500 🔴 (+88%) 🔻 2517 🔴 (+79%) 🔻 2604 🔴 (+67%) 🔻 30
Fan-out TTFS Promise.all(100 steps) 584 (-33%) 💚 811 (-53%) 💚 1396 (-22%) 💚 2712 (+45%) 🔻 10
Fan-out TTLS Promise.all(100 steps) 1683 (-27%) 💚 3695 (+1.8%) 4316 (+14%) 8686 (+20%) 🔻 10
STSO 1020 steps (inline) 99 (-1.0%) 126 (-3.1%) 143 (-7.1%) 204 (±0%) 1019
WO 1020 steps 128391 (-2.5%) 128391 (-2.5%) 128391 (-2.5%) 128391 (-2.5%) 1
CRTT first chunk (pooled) 55 (-24%) 💚 75 (-47%) 💚 156 (-26%) 💚 231 (-35%) 💚 28

Streams

Scenario CRTT 1st p75 p90 p99 CDV max iters
paced control (100/s, 60B) 62.5 (-37%) 115 (-40%) 203 (-33%) 484 (-2%) 127 (-44%) 10
size sweep (100/s, 160B-12KB) 62.5 (-40%) 122 (-46%) 389 (+10%) 719 (+14%) 147 (-30%) 10
replay gateway-gpt-5.4-nano-2000t (1x) 59 (-57%) 110 (-42%) 139 (-57%) 269 (-53%) 195 (-55%) 3
replay eve-gpt-5.6-sol-2000t (1x) 79 (-24%) 120 (-39%) 438 (+43%) 3121 (+467%) 1557 (+242%) 2
replay eve-gpt-5.6-sol-2000t (2x) 105 (-26%) 149 (-54%) 197 (-60%) 296 (-69%) 254 (-46%) 3
📈 STSO distribution vs main (inline / queue-hop histograms)

1020 steps (inline)

Cumulative STSO time: main 131526ms → this run 128036ms (Δ -3490ms, -3%)

 50-100 ms  ┃                         main   0  this   1    +1
100-150 ms  ███████████████████████┃  main 899  this 947   +48
150-200 ms  ┃██                       main 108  this  58   -50
200-250 ms  ┃                         main   8  this  10    +2
250-300 ms  ┃                         main   2  this   3    +1
350-400 ms  ┃                         main   1  this   0    -1
400-450 ms  ┃                         main   1  this   0    -1
📈 CRTT drill-down vs main (RTT distributions & profiles)
variant  RTT 1ms→5s+             avg         p50         p90           p99     n
control  ······█▅▁····  102.5 (-35%)   91 (-34%)  203 (-33%)     484 (-2%)  3000
sweep    ······█▆▁▁···  118.6 (-33%)   94 (-39%)  389 (+10%)    719 (+14%)  3000
gw 1x    ·····▁█▅▁····   97.9 (-39%)   92 (-32%)  139 (-57%)    269 (-53%)  5295
eve 1x   ·····▁█▆▁▁▁▁·  184.9 (+14%)   95 (-30%)  438 (+43%)  3121 (+467%)  5186
eve 2x   ·····▁▆█▁····  117.6 (-49%)  106 (-51%)  197 (-60%)    296 (-69%)  7779

RTT over stream progress (avg per tenth of stream, bars scaled min→max):

control  ▃▂▆▃█▅▄▂▁▄  88–124ms
sweep    ▂▁▆█▇▅▁▃▇▇  96–139ms
gw 1x    █▄▆▄▂▅▃▁▂▅  89–109ms
eve 1x   ▁▁▁▁▁▁▁█▅▁  90–624ms
eve 2x   ▄▄▁▁▃▄█▆█▃  105–132ms

RTT by chunk size (avg per log size bin, ~160B → ~12KB serialized, bars scaled min→max):

sweep  █▆▄▆▃▁▂  117–120ms

Delivery jitter over stream progress (avg positive CDV per tenth of stream, bars scaled min→max):

control  ▄▁█▂█▃▃▁▄▆  27–37ms
sweep    ▅▁▅▃▇▂▃▆▆█  34–51ms
gw 1x    █▇▇▂▄▇▃▂▁▆  25–31ms
eve 1x   ▃▁▁▂▃▁▃█▂▂  17–50ms
eve 2x   ▆▄▁▂█▆▅▂▄▇  18–25ms
ℹ️ Metric definitions & methodology

Streams: first-chunk RTT (the stream-open path, before any buffering/backpressure), CRTT percentiles, and worst delivery stall (CDV max). Cells are medians across iterations; per-run values in the artifacts. No 🔴/🟢 marks until targets attach.

The collapsed STSO distribution section above buckets every step gap, split inline (same warm process — pure framework overhead) vs queue-hop (fresh process — dispatch, reinit, replay). █ = main, ┃ = this run, ░ = fill.

The collapsed CRTT drill-down: per-variant RTT histograms (fixed log bins, · = empty) and mean RTT/positive-CDV profile lines over stream progress and chunk size. Histograms, avgs, and profiles merge exactly across runs; p50–p99 are percentile-of-percentiles. Per-index rows live in the artifacts.

Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.

Metrics — TTFS: time to first step body (in-deployment start() → first step body) · Fan-out TTFS: fan-out time to first step (in-deployment start() → first of the parallel step bodies to complete) · Fan-out TTLS: fan-out time to last step (in-deployment start() → last of the parallel step bodies to complete, i.e. when the Promise.all resolves) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · CRTT: chunk round-trip time (per-chunk write → read latency, one clock domain: deployment → stream backend → same deployment) · CDV: chunk delay variation / delivery jitter (inter-arrival gap minus inter-write gap per seq-adjacent pair; skew-free; the row is each run's MAX positive value, so one stall moves it)

Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · Promise.all(100 steps): 100 trivial no-op steps started together in a single Promise.all; Fan-out TTFS is the first of them to complete and Fan-out TTLS the last, both from the in-deployment clientStart, so their gap is the spread the runtime adds across the fan-out · paced control (100/s, 60B): the control: 300 tiny (~60B) deltas metronome-paced at 100/s — zero workload structure, so it reads the transport floor and flush cadence, and disambiguates transport-wide vs workload-specific when a replay row moves · size sweep (100/s, 160B-12KB): same pacing as the control with deltas padded in rotation across seven log-spaced sizes (~160B–12KB) — rotation decouples size from stream position, so it isolates whether chunk size causes latency · replay gateway-gpt-5.4-nano-2000t (1x): raw provider SSE cadence captured at the AI gateway boundary (gpt-5.4-nano, the most popular gateway model; per-token deltas p50 208B = the modal production chunk size), replayed exactly as measured — the typical customer's workload; its CDV is the typical customer's real delivery jitter · replay eve-gpt-5.6-sol-2000t (1x): a captured eve turn (gpt-5.6-sol, the most-used demanding eve model; ~2000 output tokens = production p50 turn length) replayed exactly as measured — eve's envelope protocol re-ships the cumulative message so sizes ramp 142B→13KB; the demanding outlier tenant's reality · replay eve-gpt-5.6-sol-2000t (2x): the same eve capture at 2x — the headroom/stress row; real fast-tier models emit the same chunk sizes at proportionally higher rate, so time compression is a faithful speed model · first chunk (pooled): every run's seq-0 RTT pooled across all stream scenarios — the first chunk precedes any workload differentiation, so pooling samples one shared stream-open path with exact percentiles

Replay cadences (semantic sha256) — eve-gpt-5.6-sol-2000t eaf22f5946e7c61f3c65c7006d550df180cfabd4e706254a09f22aec0cfb420d · gateway-gpt-5.4-nano-2000t 6f24ac518b6b83ff1d0e85a5fe78230db192716d66a7fc6b2fe022752001d041

🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600

All timestamps are deployment-side; runs are triggered in-deployment, so the CI runner and api.vercel.com sit outside every measured window. TTFS = start() → first step body (includes dispatch + any cold start); Fan-out TTFS/TTLS = first/last step completion of one Promise.all from the same anchor (the gap is the runtime’s fan-out spread); STSO/WO between step bodies; CRTT inside the workflow (excludes the api.vercel.com read path).

Cold starts stay in the numbers (real bursty-workload latency, inflates P75+); Best is the warm floor.

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Sim World

Simulated world deterministic testing for races. Traces

🟠 world-sim scenario book — 1 fail of 42 total

fence=per-spec

scenario outcome events virt replay violations
✅ smoke-no-steps completed 3 0ms ok 0
✅ smoke-one-step completed 6 0ms ok 0
✅ hook-at-step-started completed 12 0ms ok 0
✅ hook-at-step-completed completed 12 0ms ok 0
✅ hook-at-hook-created completed 12 0ms ok 0
✅ deadline-hook-wins completed 7 1.0h ok 0
✅ deadline-expires completed 7 1.0h ok 0
✅ step-vs-timer-early-settlement completed 8 1.0h ok 0
✅ long-sleep completed 11 30.0d ok 0
✅ hook-never-arrives stalled 3 0ms skipped 0
✅ step-retries-twice completed 10 2.0s ok 0
✅ parallel-steps completed 9 0ms ok 0
✅ hook-on-execution-state completed 12 0ms ok 0
✅ peek-hook-before-branch completed 12 0ms ok 0
✅ peek-hook-after-branch completed 12 0ms ok 0
✅ peek-hook-at-registration completed 12 0ms ok 0
✅ race-hook-before-probe completed 12 0ms ok 0
✅ race-hook-after-probe completed 12 0ms ok 0
✅ race-duplicate-delivery completed 13 0ms ok 0
✅ attr-hook-before-step completed 11 0ms ok 0
✅ attr-hook-after-step completed 11 0ms ok 0
✅ attr-from-step-body completed 13 0ms ok 0
✅ fork-hook-after-timeout completed 14 1.0m ok 0
✅ fork-hook-before-timeout completed 14 1.0m ok 0
✅ count-hook-after-timeout completed 17 1.0m ok 0
✅ count-hook-before-timeout completed 20 1.0m ok 0
✅ stale-read-step-count-fork completed 20 1.0m ok 0
✅ stale-read-equal-step-counts completed 14 1.0m ok 0
✅ step-vs-step-fork completed 12 0ms ok 0
✅ step-vs-step-fork-fenced completed 12 0ms ok 0
✅ fence-catches-benign-direction completed 12 5ms ok 0
✅ in-flight-before-decision completed 17 1.0m ok 0
❌ in-flight-before-decision-counted completed 17 1.0m ok 0
✅ in-flight-after-decision completed 19 2.0m ok 0
✅ stale-read-step-count-fork-fenced completed 20 1.0m ok 0
✅ fork-hook-wins completed 13 1.0m ok 0
✅ fork-timeout-wins completed 13 1.0m ok 0
✅ unclaimed-payload-under-fork completed 17 1.0m ok 0
✅ claimed-payload-under-fork completed 17 1.0m ok 0
✅ writers-independent-step-bodies completed 12 0ms ok 0
✅ writers-scripted-tempo completed 12 0ms ok 0
✅ cancel-mid-step cancelled 7 0ms skipped 0

Full trace: world-sim.txt

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor
Framework Flow route Step reg. Framework output
hono 267.2 KiB (±0) 97.3 KiB (±0) 2.01 MiB (-229 B)
nextjs-turbopack 274.6 KiB (±0) 426 B (±0) 986.2 KiB (-171 B)
About these numbers

Sizes are gzip; parentheses show the change against main.
Flow route and Step reg. gate this job, on raw bytes rather than the gzip shown, at max(2%, 50.0 KiB). Framework output is informational.

a166e18 · run

@alangenfeld
alangenfeld marked this pull request as ready for review October 5, 2026 17:09
@alangenfeld
alangenfeld requested a review from a team as a code owner October 5, 2026 17:09

@karthikscale3 karthikscale3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the cross-instance hook publication race fix and its slot-collision behavior. The targeted world-local tests pass (20/20), including the new deterministic regression coverage. No blocking issues found.

@alangenfeld
alangenfeld merged commit 2d2159e into main Oct 5, 2026
187 of 188 checks passed
@alangenfeld
alangenfeld deleted the alangenfeld/workflow-ci-health-investigation branch October 5, 2026 17:34
@github-actions github-actions Bot mentioned this pull request Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

No backport to stable for 2d2159e (AI decision).

This is a genuine correctness fix (duplicate hook_created events), but it patches the event-slot claim/stage/bump machinery in packages/world-local/src/storage/events-storage.ts that exists only on main — origin/stable has no bumpEventSlot, promoteExclusive, notePublishedSlot, ReadEventSchema, or staged-path publish, and implements hook creation via a different canonical-eventId + writeExclusive design. The fix (and its new test, which also depends on the main-only path) therefore addresses a defect that stable does not have.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

2d2159e6c7b6dce3fc69d33e0e94839f3e941bc4

This branch was successfully deployed

1 active deployment
Preview – workflow-docs — a166e182 Deployed Oct 5, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants