Skip to content

Add reusable conversation delegation policy - #1511

Merged
kojiwakayama merged 1 commit into
mainfrom
move-conversation-delegation-policy-to-framework
May 9, 2026
Merged

kojiwakayama merged 1 commit into
mainfrom
move-conversation-delegation-policy-to-framework

Conversation

@kojiwakayama

Copy link
Copy Markdown
Contributor

Summary

  • add reusable conversation delegation and load-skill continuation policy helpers
  • export root-ownership, starter-intent, and delegated-findings guidance constants from the framework agent surface
  • bump package version to 0.1.443 for publication through CI/CD

Verification

  • deno test --no-check --allow-all src/agent/conversation-delegation-policy.test.ts
  • deno check src/agent/conversation-delegation-policy.ts src/agent/conversation-delegation-policy.test.ts src/agent/index.ts
  • deno lint src/agent/conversation-delegation-policy.ts src/agent/conversation-delegation-policy.test.ts src/agent/index.ts
  • deno fmt --check src/agent/conversation-delegation-policy.ts src/agent/conversation-delegation-policy.test.ts src/agent/index.ts deno.json src/utils/version-constant.ts
  • deno check src/index.ts
  • pre-push hook: format, lint, typecheck, unit tests

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8984e0e8ad

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +219 to +220
if (typeof instructions === "string") {
return `${instructions}\n\n${LOAD_SKILL_CONTINUATION_REMINDER}`;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid duplicating reminders for string instructions

When a caller keeps system instructions as a string and applies this helper on each model step after a trailing load_skill result, this branch appends the full critical reminder every time. The ChatSystemMessage[] branch is idempotent, so string-based integrations can grow the prompt and repeat the same system instruction across retries or steps; guard with instructions.includes(LOAD_SKILL_CONTINUATION_REMINDER) before appending.

Useful? React with 👍 / 👎.

@kojiwakayama
kojiwakayama merged commit 73935bf into main May 9, 2026
18 checks passed
@kojiwakayama
kojiwakayama deleted the move-conversation-delegation-policy-to-framework branch May 9, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant