fix: remove unused react-dom/client mapping from dnt build - #271
Merged
Merged
Conversation
The API surface refactor (#264) reduced exports to 18 flat paths, none of which transitively import react-dom/client. dnt fails when a mapping is specified but no entry point source file references it.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the npm packaging pipeline by removing an unnecessary react-dom/client esm.sh mapping from the dnt build script, aligning the mapping list with the current (reduced) public entrypoint module graph so dnt no longer errors on an unused mapping.
Changes:
- Removed the
https://esm.sh/react-dom@19.1.1/client?...→react-dom/clientmapping from the dntmappingsconfig.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ariskemper
pushed a commit
that referenced
this pull request
Feb 9, 2026
The API surface refactor (#264) reduced exports to 18 flat paths, none of which transitively import react-dom/client. dnt fails when a mapping is specified but no entry point source file references it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
react-dom/clientesm.sh mapping from the dnt build scriptreact-dom/clientTest plan
deno run -A scripts/build/build-npm-dnt.tscompletes successfully