Rebuild up as a Deploy Execution adapter

[kojiwakayama]

Summary

Stacked on #3190 (consumes the Project Resolution module). Two commits:

1. Rebuild up as a Deploy Execution adapter — veryfront up previously composed pushCommand + deployCommand({skipSourcePush}) around what DeployProject.execute already owns end-to-end, then discarded the verified deployment URL and printed one rebuilt via buildPushUrls on the {slug}.preview.veryfront.com pattern. Those coincide only for a domain-less preview environment on an app with no static page route — with a configured domain or a probed route path, the old output handed users a hostname nobody had checked. Now: one DeployProject.execute call (source ensure-pushed, branch main, env preview), and the printed/JSON previewUrl is the outcome's verified URL. Injection unified on the MCP style (dependencies: { deployProject? }). Progress text shared via cli/shared/deployment/progress.ts (moved verbatim). JSON field names and dry-run plannedActions shape unchanged.

Deliberate behavior changes (commit body): dry-run with a valid main receipt omits push-source from the plan (deploy wouldn't push); dry-run with a receipt for another branch now surfaces the mismatch error instead of silently planning — pinned by an exact-message integration test that also asserts zero control-plane mutations.

2. Retire the deploy command's bespoke testing seams — deployCommandWithProjectForTesting + DeployCommandTestingSeams deleted; suppressJsonOutput and the four never-parseable polling knobs dropped from DeployOptions (polling now reaches the module via createDeployProject({ polling })); skipSourcePush kept as the only command-boundary expression of source already-pushed (eight integration assertions ride it), flagged for removal once a user-facing flag exists.

Tests: the up suite no longer monkey-patches globalThis.fetch (was 6×) — it injects a fake DeployProject and finally asserts what deploy was asked to do, plus a new end-to-end suite over the real module with InMemoryDeployControlPlane (verified-URL provenance: output must carry the control plane's domain and must NOT contain the rebuilt pattern).

Review

Independent code-review pass: approve, no blocking issues. Its one Low item (no pinning test for the stale-receipt dry-run change) is closed by the exact-message test above — which also corrected the review's own guess at the error (it's the validatePushReceipt branch-check error, not SOURCE_DIGEST_MISMATCH).

Tested

• Targeted: 52 passed / 250 steps, 0 failed; typecheck, lint, fmt, cli-boundary, module-boundaries green; test-typecheck baseline holds (92 grandfathered, 0 new)
• Pre-push full suite: 2806 passed / 22,739 steps, 0 failed

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

The base branch was changed.

[Copilot]

Pull request overview

This PR refactors veryfront up to delegate end-to-end work to the Deploy Execution module (DeployProject.execute) so up prints/returns the verified preview URL produced by Deploy Execution, and it simplifies the deploy command adapter by removing bespoke testing seams in favor of dependency injection.

Changes:

• Rebuild up to call Deploy Execution directly (apply/dry-run), stream consistent progress text, and output the verified previewUrl (human + JSON).
• Extract shared deploy progress messaging into cli/shared/deployment/progress.ts and reuse it from both deploy and up.
• Update integration/unit tests to inject a fake DeployProject (unit) or use an in-memory control plane (E2E-style integration), and re-enable sanitizers (baseline lowered accordingly).

Verification

• Not run in this review environment. Safest next step: run the repo’s targeted CLI tests, then broaden if needed:
  • deno test --no-check --allow-all --unstable-worker-options --unstable-net cli/commands/up/command.test.ts cli/commands/up/up.integration.test.ts cli/commands/deploy/command.test.ts cli/commands/deploy/command.integration.test.ts
  • Then: VF_DISABLE_LRU_INTERVAL=1 SSR_TRANSFORM_PER_PROJECT_LIMIT=0 REVALIDATION_PER_PROJECT_LIMIT=0 NODE_ENV=production LOG_FORMAT=text deno test --no-check --allow-all --unstable-worker-options --unstable-net

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
scripts/lint/check-sanitizer-baseline.ts	Lowers sanitizer opt-out baseline after re-enabling sanitizers in the up integration suite.
cli/shared/deployment/progress.ts	Introduces shared human progress text mapping for Deploy Execution step events.
cli/commands/up/up.integration.test.ts	Adds end-to-end coverage that asserts up prints/returns the control-plane-verified preview URL and avoids the rebuilt hostname pattern.
cli/commands/up/command.ts	Replaces push+deploy composition with a single Deploy Execution call; prints/streams verified URLs; introduces dependency injection for tests.
cli/commands/up/command.test.ts	Refactors unit tests to inject a fake DeployProject and assert requested deploy behavior + verified URL handling.
cli/commands/deploy/command.ts	Removes bespoke testing seams/options; injects DeployProject directly; reuses shared progress text.
cli/commands/deploy/command.test.ts	Updates adapter tests to use deployCommand with injected deployProject.
cli/commands/deploy/command.integration.test.ts	Uses a bounded-polling Deploy Execution instance for integration stability without adding adapter-only polling knobs.

Suppressed comments (4)

cli/commands/up/command.test.ts:290

• This withMockFetch handler returns an identity response for any request. Tighten it to only allow /me (and throw otherwise) so the test reliably catches unexpected fetch orchestration outside Deploy Execution.

        const { output } = await captureLog(() =>
          withMockFetch(
            () => Promise.resolve(identityResponse()),
            () => upCommand({ projectDir }, authenticatedEnv(projectDir), { deployProject }),
          )
        );

cli/commands/up/command.test.ts:329

• This fetch stub responds with identityResponse() for any request, which can hide unexpected additional fetches during JSON mode. Restrict it to /me and throw on other paths to keep the test fail-closed.

        const { output } = await captureLog(() =>
          withMockFetch(
            () => Promise.resolve(identityResponse()),
            () => upCommand({ projectDir }, authenticatedEnv(projectDir), { deployProject }),
          )
        );

cli/commands/up/command.test.ts:366

• This fetch stub is permissive (returns an identity response for any request). Consider throwing on non-/me paths so the dry-run adapter test fails if upCommand starts making extra network requests.

        const { output } = await captureLog(() =>
          withMockFetch(
            () => Promise.resolve(identityResponse()),
            () =>
              upCommand({ projectDir, dryRun: true }, authenticatedEnv(projectDir), {
                deployProject,
              }),
          )
        );

cli/commands/up/command.test.ts:409

• This fetch stub accepts any request and always returns an identity response. Restricting it to /me helps ensure the test fails if upCommand unexpectedly performs other fetches during planning.

        const { output } = await captureLog(() =>
          withMockFetch(
            () => Promise.resolve(identityResponse()),
            () =>
              upCommand({ projectDir, dryRun: true }, authenticatedEnv(projectDir), {
                deployProject,
              }),
          )
        );

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

Suppressed comments (1)

cli/shared/deployment/progress.ts:38

• deployProgressText() is declared to return string | null, but the switch can fall through and implicitly return undefined if a new DeployStepName is added and not handled here. Add an explicit return null after the switch to keep the runtime behavior aligned with the type contract.

    case "wait-environment-url":
      return verbose ? `Waiting for ${environment} URL...` : `Verifying ${environment} URL...`;
  }
}