chore: gitignore the SDD scratch workspace and drop a dead export - #3447
Merged
Merged
Conversation
.superpowers/ is a scratch workspace written by review tooling (implementation reports, generated review diffs). docs/superpowers/ was already gitignored but .superpowers/ was not, and scratch files from it leaked into a real PR as a result.
No production consumer exists -- only build-executor.test.ts used it, and it's not re-exported from the release-assets barrel. Delete it along with the two test cases that existed solely to exercise it; the underlying dependencyUrlForSpecifier helper stays, still exercised via runReleaseAssetBuild's other test coverage.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
kojiwakayama
enabled auto-merge
August 7, 2026 03:53
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThe change removes the exported dependency URL lookup wrapper and its related tests. It also adds the ChangesRelease asset API cleanup
Workspace ignore rule
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small, unrelated hygiene changes, one commit each.
1. Gitignore
.superpowers/docs/superpowers/is already ignored (.gitignore:90), but.superpowers/— a scratch workspace written by review tooling (implementation reports, generated review diffs) — was not. Two scratch files leaked into #3441 because of this and had to be removed after review caught them.Verified before:
git check-ignore -v .superpowersexited 1. Verified after against a real file under the directory, matching.gitignore:105. (Checking a nonexistent bare path is unreliable for a trailing-slash pattern — it can exit 1 even when the pattern would match, so the real-file test is the one that counts.)2. Delete
releaseAssetDependencyUrlForSpecifierNo production consumer. Repo-wide grep across
src/andcli/found exactly five hits: the definition atbuild-executor.ts:732and four usages inside its own test. Not re-exported fromsrc/release-assets/index.ts, anddeno.jsonmapsveryfront/release-assetsto the barrel only.Removed the exported wrapper plus the two
it()blocks that existed solely to exercise it. The private helper it wrapped,dependencyUrlForSpecifier, stays — still used internally at lines 654, 658 and 2026, and still covered by therunReleaseAssetBuildtests.Evidence
deno task test:unit: 3801 passed / 27915 steps → 3801 / 27913. Delta is −2 steps, exactly the two deleted cases; 0 failed in both runs. (The top-level count is unchanged because Deno's BDDit()cases nest as steps under the file-level test.)deno task verify:quickexit 0;deno lintanddeno check src/index.tsclean.Summary by CodeRabbit
Refactor
Chores