Skip to content

chore: gitignore the SDD scratch workspace and drop a dead export - #3447

Merged
kojiwakayama merged 2 commits into
mainfrom
chore/repo-hygiene
Aug 7, 2026
Merged

kojiwakayama merged 2 commits into
mainfrom
chore/repo-hygiene

Conversation

@kojiwakayama

@kojiwakayama kojiwakayama commented Aug 7, 2026 •

Copy link
Copy Markdown
Contributor

Two small, unrelated hygiene changes, one commit each.

1. Gitignore .superpowers/

docs/superpowers/ is already ignored (.gitignore:90), but .superpowers/ — a scratch workspace written by review tooling (implementation reports, generated review diffs) — was not. Two scratch files leaked into #3441 because of this and had to be removed after review caught them.

Verified before: git check-ignore -v .superpowers exited 1. Verified after against a real file under the directory, matching .gitignore:105. (Checking a nonexistent bare path is unreliable for a trailing-slash pattern — it can exit 1 even when the pattern would match, so the real-file test is the one that counts.)

2. Delete releaseAssetDependencyUrlForSpecifier

No production consumer. Repo-wide grep across src/ and cli/ found exactly five hits: the definition at build-executor.ts:732 and four usages inside its own test. Not re-exported from src/release-assets/index.ts, and deno.json maps veryfront/release-assets to the barrel only.

Removed the exported wrapper plus the two it() blocks that existed solely to exercise it. The private helper it wrapped, dependencyUrlForSpecifier, stays — still used internally at lines 654, 658 and 2026, and still covered by the runReleaseAssetBuild tests.

Evidence

  • deno task test:unit: 3801 passed / 27915 steps → 3801 / 27913. Delta is −2 steps, exactly the two deleted cases; 0 failed in both runs. (The top-level count is unchanged because Deno's BDD it() cases nest as steps under the file-level test.)
  • deno task verify:quick exit 0; deno lint and deno check src/index.ts clean.
  • Each commit touches only its own files.

Summary by CodeRabbit

  • Refactor

    • Removed an unused release asset dependency URL utility.
    • Simplified internal release asset handling without changing dependency resolution behavior.
  • Chores

    • Excluded tooling scratch files from version control.

.superpowers/ is a scratch workspace written by review tooling
(implementation reports, generated review diffs). docs/superpowers/
was already gitignored but .superpowers/ was not, and scratch files
from it leaked into a real PR as a result.
No production consumer exists -- only build-executor.test.ts used it,
and it's not re-exported from the release-assets barrel. Delete it
along with the two test cases that existed solely to exercise it; the
underlying dependencyUrlForSpecifier helper stays, still exercised via
runReleaseAssetBuild's other test coverage.
@kojiwakayama
kojiwakayama requested a review from kwakayama as a code owner August 7, 2026 03:53
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@kojiwakayama
kojiwakayama enabled auto-merge August 7, 2026 03:53
@coderabbitai

coderabbitai Bot commented Aug 7, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c4063069-964d-491b-be1f-031788b21c80

📥 Commits

Reviewing files that changed from the base of the PR and between e0ec3a2 and 91201e5.

📒 Files selected for processing (3)
  • .gitignore
  • src/release-assets/build-executor.test.ts
  • src/release-assets/build-executor.ts
💤 Files with no reviewable changes (2)
  • src/release-assets/build-executor.ts
  • src/release-assets/build-executor.test.ts

📝 Walkthrough

Walkthrough

The change removes the exported dependency URL lookup wrapper and its related tests. It also adds the .superpowers/ SDD tooling workspace to .gitignore.

Changes

Release asset API cleanup

Layer / File(s) Summary
Remove dependency URL wrapper
src/release-assets/build-executor.ts, src/release-assets/build-executor.test.ts
The public releaseAssetDependencyUrlForSpecifier wrapper and its unused import are removed. Tests for HTTP query and fragment identity handling are deleted.

Workspace ignore rule

Layer / File(s) Summary
Ignore SDD workspace
.gitignore
The .superpowers/ SDD review tooling scratch workspace is added to the ignore rules.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: kwakayama

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes both repository hygiene changes: ignoring the SDD scratch workspace and removing the dead export.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/repo-hygiene

Comment @coderabbitai help to get the list of available commands.

@kojiwakayama
kojiwakayama added this pull request to the merge queue Aug 7, 2026
Merged via the queue into main with commit ded1750 Aug 7, 2026
31 checks passed
@kojiwakayama
kojiwakayama deleted the chore/repo-hygiene branch August 7, 2026 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant