Bound integration tool discovery per run - #3515
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe change adds scoped remote integration tool discovery with cached success or unavailable results. Agent runtime steps preserve discovery status and update prompts for unavailable discovery. The public API and generated reference documentation expose the new function and result type. ChangesRemote integration discovery
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/agent/runtime/agent-runtime-step.ts`:
- Around line 111-114: Update the unavailable-discovery message in the runtime
step to use model-facing wording: address the model as “you” and express the
prohibition with “must not,” while preserving the instructions to explain
temporary unavailability and ask the user to retry.
- Around line 96-102: Update removeIntegrationToolDiscoveryStatus so it removes
the delimited status block wherever it appears in systemPrompt, including when
suffix content follows the footer, while preserving all surrounding prompt text.
Add a regression test covering suffix content after an existing status block and
verify subsequent status updates do not retain duplicate blocks.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 650d2254-9924-4de2-b3ca-ce06f5f158dc
📒 Files selected for processing (10)
docs/api-reference/veryfront/agent.mddocs/api-reference/veryfront/integrations.mdscripts/docs/generate-api-reference.tssrc/agent/runtime/agent-runtime-step.test.tssrc/agent/runtime/agent-runtime-step.tssrc/agent/runtime/index.tssrc/agent/runtime/tool-helpers.tssrc/integrations/index.tssrc/integrations/remote-tools.test.tssrc/integrations/remote-tools.ts
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5eae33a9c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Closes veryfront/veryfront-issue-inbox#8
Summary
Verification
VF_DISABLE_LRU_INTERVAL=1 deno test --no-check --allow-all src/integrations/remote-tools.test.ts src/integrations/remote-tools.hardening.test.ts src/integrations/index.test.ts src/agent/runtime/agent-runtime-step.test.ts src/agent/runtime/tool-helpers.test.tsVF_DISABLE_LRU_INTERVAL=1 DENO_TESTING=1 NODE_ENV=production LOG_FORMAT=text deno test --no-check --allow-all --parallel src/agent/runtime(496 passed, 592 steps)deno task verify:quickgit diff --checkSummary by CodeRabbit
New Features
Bug Fixes
Documentation