Conversation
Ships the build fixes for veryfront-issue-inbox#456. `veryfront build` has been broken for every project since 0.1.1206, and 5 of 7 scaffold templates could not build at all. - #3538 prime host contracts in the build extension path - #3541 resolve server-side esm.sh modules with a server target - #3542 keep optional Deno imports optional - #3540 isolate cwd-mutating unit tests There is no earlier version to pin to: 0.1.1205 fails the same templates with the CSSProcessor error that #3417 was fixing.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe release version changed from ChangesRelease version update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 22e3eea8b3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Pull request was closed
Cuts v0.1.1228, the release that unblocks
veryfront build.Merging this publishes:
version-check(cicd.yml:469) comparesdeno.jsonagainst the previous commit, and a changed stable version gates thereleasejob.Why this release matters
veryfront buildhas been broken for every project since 0.1.1206 — 22 releases. An external report surfaced it on 0.1.1227 (veryfront-issue-inbox#456).There is no earlier version to pin to. 0.1.1205 fails the same templates with the
CSSProcessorerror that #3417 was fixing. A release is the only fix path.What ships
Verification on merged main (
48cd2d5c7)All 7 scaffold templates, each
veryfront init+veryfront buildfrom scratch:minimalai-agent(default)docs-agentagentic-workflowmulti-agent-systemcoding-agentsaas-starterBefore these fixes, 5 of the 7 failed. Page counts are included because
veryfront buildcan exit 0 with zero pages, so "built" alone is not evidence.Hydration checked in a real browser on the
docs-agentbuild served viaveryfront serve: 428 requests all 200, zero console messages, React fibers attached. That matters because #3541 makes SSR evaluate esm.sh'snodebuild while the browser still getses2022, and a parity break there would be invisible to CI.Diff
Two lines.
deno.jsonandsrc/utils/version-constant.tsmust move together;src/utils/version.test.ts:25enforces it.Summary by CodeRabbit