Skip to content

fix(test): close remaining Bun review gaps - #3548

Closed
kojiwakayama wants to merge 3 commits into
mainfrom
fix/cross-runtime-review-followup
Closed

kojiwakayama wants to merge 3 commits into
mainfrom
fix/cross-runtime-review-followup

Conversation

@kojiwakayama

Copy link
Copy Markdown
Contributor

Summary

  • serialize stale Bun workspace-lock reclamation without deleting the canonical lock directory
  • add a two-process regression proving a concurrent reclaimer cannot remove the live replacement owner
  • normalize Bun preload paths across slash styles and cover extension and test rewrites
  • convert the Bun runner test URL with fileURLToPath for Windows

This follow-up addresses all three review threads that completed as PR #3543 entered the merge queue.

Verification

  • node --test tests/bun/runner-args.test.mjs tests/bun/workspace-packages.test.mjs, 14 passed
  • concurrent stale-lock regression, 20/20 isolated runs passed
  • Bun 1.3.6 npm-protocol focused suite, 3 passed
  • full Bun isolation runner, 1296 files passed; one pre-existing macOS native watcher assertion fails locally and is unchanged by this diff
  • deno lint on all six changed files
  • deno fmt --check on all six changed files
  • git diff --check

@coderabbitai

coderabbitai Bot commented Aug 10, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@kojiwakayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 14 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 10505e5c-7806-4f24-b15c-54b00546f1c7

📥 Commits

Reviewing files that changed from the base of the PR and between 80fb3a0 and 79a73e3.

📒 Files selected for processing (6)
  • tests/bun/npm-protocol-imports.ts
  • tests/bun/npm-protocol-resolution.test.ts
  • tests/bun/preload.ts
  • tests/bun/runner-args.test.mjs
  • tests/bun/workspace-packages.mjs
  • tests/bun/workspace-packages.test.mjs
✨ Finishing Touches 💡 1
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch fix/cross-runtime-review-followup
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cross-runtime-review-followup

Comment @coderabbitai help to get the list of available commands.

@kojiwakayama
kojiwakayama force-pushed the fix/cross-runtime-review-followup branch from db67f26 to 004eef7 Compare August 10, 2026 17:37

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: db67f26dc2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/bun/workspace-packages.mjs Outdated
Comment thread tests/bun/workspace-packages.test.mjs Fixed
@kojiwakayama

Copy link
Copy Markdown
Contributor Author

@codex review

@kojiwakayama

Copy link
Copy Markdown
Contributor Author

Superseded by #3551. Follow-up race review showed the interim reclaimer could either wedge after a crash or expose a later live lock to a delayed stale reader. The replacement uses generation-scoped atomic tombstones and passed the complete Bun gate (16 harness tests and 1297 Bun test files).

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 79a73e3b1e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kojiwakayama
kojiwakayama deleted the fix/cross-runtime-review-followup branch August 30, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants