Render invoke-agent tool cards - #3593
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughThe chat tool UI now renders default Changesinvoke_agent UI
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant ToolCallRoot
participant InvokeAgentToolCall
participant Status
ToolCallRoot->>InvokeAgentToolCall: route default invoke_agent call
InvokeAgentToolCall->>Status: render derived child-agent status
InvokeAgentToolCall-->>ToolCallRoot: render collapsible child-agent card
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
kwakayama
marked this pull request as ready for review
August 11, 2026 17:12
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f98b66c20
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/api-reference/veryfront/chat.md`:
- Line 211: Update the ToolCall entry in the API reference to document that
invoke_agent calls render child-agent cards by default, while caller-provided
children replace the default renderer. Preserve the existing generic
default-card and compound-layout guidance.
In `@src/react/components/chat/chat/components/tool-ui.tsx`:
- Around line 399-405: The default invoke_agent early-return branch in the tool
UI component drops the generic root props. Update the InvokeAgentToolCall path
to forward className and ref to the child-agent card root, matching the generic
rendering path while preserving existing ToolCall consumer behavior, and add a
regression test verifying className forwarding.
- Around line 302-305: Update the failure-card rendering around ToolCallRoot and
showDetail so the detail visibility matches isExpanded, including structured
failures without tool.errorText; alternatively initialize isExpanded from the
invoke-agent failure signal. Ensure aria-expanded and toggling remain
consistent, and add an assertion that the structured failure fixture starts
collapsed.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: b30f1ef5-f300-493f-9e50-9f6e989fdd09
⛔ Files ignored due to path filters (1)
src/server/handlers/dev/framework-candidates.generated.tsis excluded by!**/*.generated.*
📒 Files selected for processing (3)
docs/api-reference/veryfront/chat.mdsrc/react/components/chat/chat/components/tool-ui.test.tsxsrc/react/components/chat/chat/components/tool-ui.tsx
Contributor
Author
Agent-browser visual proofCaptured from the PR branch at a 1000 × 360 viewport. Verified with no page errors. Running (collapsed)
Running (expanded)
Completed
Failed (expanded)
Stopped
Custom renderer override
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The generic tool row exposed invoke_agent as an implementation detail. Child-agent runs should read like the agent cards in Veryfront Studio without adding a new public rendering API.
Validation
Summary by CodeRabbit
New Features
Bug Fixes
Documentation