Repository navigation
Keep merge-group review resolution independent of wakeup runs - #4161
Conversation
A live merge-queue canary showed that the shared target resolver treated the absent workflow_run payload on merge_group events as an unsuccessful review wakeup. Scope the conclusion guard to workflow_run events while retaining fail-closed handling for actual wakeup failures. Constraint: Merge-group events do not include a workflow_run payload. Rejected: Treat a missing workflow_run conclusion as success globally | that would weaken failure handling for actual wakeup events. Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep merge-group target resolution independent from workflow-run-only payload fields. Tested: automated-review-gate 67 steps; fmt check; lint; focused and project typecheck; generated artifacts; git diff check. Not-tested: Live merge-group propagation until this commit enters the queue.
There was a problem hiding this comment.
kojiwakayama has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
You have reached your Codex usage limits for security reviews. Please try again later. |
|
Warning Review limit reachedNext included review available in 36 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
📦 Client bundle boundary
A server module in a client graph aborts hydration in the browser. New leaks fail CI; known leaks are tracked in |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Why
The first live merge-queue canary for the automated review gate exposed a false failure: merge-group events do not carry a workflow_run payload, but the shared resolver required workflow_run.conclusion to be success for every event type.
Change
Evidence
The Automated review check is not yet required. Human approval remains required until this PR proves source and merge-group propagation end to end.