fix: support .jsx, .ts, .js extensions in named layout resolution - #420
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1f9df9f1e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ariskemper
force-pushed
the
fix/layout-entity-missing-extensions
branch
from
February 23, 2026 10:14
b1f9df9 to
72a453b
Compare
getLayoutEntity only checked .mdx, .md, .tsx when resolving named layouts. Files in layouts/ are now treated as layouts by convention in getLayoutEntity without modifying detectEntityType, avoiding misclassification of route pages under pages/layouts/.
ariskemper
force-pushed
the
fix/layout-entity-missing-extensions
branch
from
February 23, 2026 10:17
72a453b to
db7225b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getLayoutEntityonly checked.mdx,.md,.tsxwhen resolving named layouts — missing.jsx,.ts,.jslayouts/directory (e.g.layouts/main.jsx) weren't found becausedetectEntityTypeonly classifies by filename/frontmatter, not directory contextChanges
.jsx,.ts,.jsto all three lookup groups ingetLayoutEntity(layouts/, components/XLayout, components/Layout)getLayoutEntitynow promotes any valid entity from thelayouts/directory to a layout, while still requiring name/frontmatter-based detection forcomponents/pathsdetectEntityTypeis left unchanged — noparentDirheuristic that could misclassify route pages underpages/layouts/Test plan
getEntityInfotests pass.jsx/.ts/.jslayouts inlayouts/andcomponents/directoriespages/layouts/index.tsxis correctly classified as a page (not a layout)basic-mdxexample usinglayouts/main.jsx