Skip to content

release: v0.1.1257 - #4417

Merged
kwakayama merged 1 commit into
mainfrom
release/v0.1.1257
Sep 5, 2026
Merged

kwakayama merged 1 commit into
mainfrom
release/v0.1.1257

Conversation

@kwakayama

Copy link
Copy Markdown
Contributor

Promotes main from 0.1.1257-rc to a clean 0.1.1257 so the release job publishes to npm --tag latest.

Why this instead of retrying 0.1.1256

veryfront-code#4414 ("release: v0.1.1256") merged, but its npm publish partially failed: 2 of 6 lockstep packages (@veryfront/ext-auth-jwt, @veryfront/ext-document-kreuzberg) published successfully; the other 4 (veryfront itself, ext-observability-opentelemetry, ext-observability-sentry, ext-sandbox-shell-tools) never did. Cause: the publish script's 5-minute wait for npm registry gitHead metadata to propagate timed out on ext-document-kreuzberg before it settled -- a registry-propagation false timeout, not a real conflict (its gitHead is correct now).

A plain retry doesn't recover this: the release job's preflight step (scripts/ci/publish-npm-packages.sh preflight) fails unconditionally on any package that already exists at the target version, with no gitHead-aware skip logic (confirmed by attempting it -- failed immediately on @veryfront/ext-auth-jwt@0.1.1256 already exists). That's a real gap in the release tooling worth a follow-up fix, but not one to make under this pressure.

Cutting forward to 0.1.1257 instead: 0.1.1256 becomes a harmless orphaned interior version (nothing ever pointed latest at it, and npm versions are immutable anyway), matching this repo's own "no redeploy, cut forward" rollback philosophy.

Files

Mirrors the v0.1.1256/v0.1.1255 releases: deno.json, src/utils/version-constant.ts, and the regenerated src/html/hydration-script-builder/hydration-runtime.generated.ts. templates/manifest.generated.ts needed no change.

Verified

  • 0.1.1257 is above both main (0.1.1257-rc) and npm latest (0.1.1255), so the release job will not no-op.
  • deno task typecheck -- exit 0, no is stale output.
  • This exact commit already has a fully-verified, published RC build: veryfront@0.1.1257-rc.18559, gitHead confirmed matching.

Note

Full incident writeup: veryfront-infrastructure#331.

Copilot AI lite review requested due to automatic review settings September 5, 2026 00:01

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kwakayama has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 19 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 202c3e23-6a5b-4947-8237-6284537e307a

📥 Commits

Reviewing files that changed from the base of the PR and between 5f8fd60 and 55977c6.

⛔ Files ignored due to path filters (1)
  • src/html/hydration-script-builder/hydration-runtime.generated.ts is excluded by !**/*.generated.*
📒 Files selected for processing (2)
  • deno.json
  • src/utils/version-constant.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-05T00:02:52.301015Z 55977c6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

📦 Client bundle boundary

Entrypoint Modules Source size Server leaks
src/index.client.ts 288 2285 KiB ✅ 0

A server module in a client graph aborts hydration in the browser. New leaks fail CI; known leaks are tracked in scripts/lint/client-bundle-baseline.json to burn down.

Copy link
Copy Markdown
Contributor Author

Code Review: Score 94/100 — Excellent

Trivial, well-justified release version-bump. Low risk, high care.

Strengths:

  • Minimal, mechanical diff (3 files, +3/-3): deno.json, src/utils/version-constant.ts, and the regenerated hydration-runtime.generated.ts — exactly the set that changes for a version bump in this repo, matching the pattern of the prior 0.1.1256/0.1.1255 releases.
  • PR description is unusually thorough for a routine release: explains why 0.1.1257 instead of retrying 0.1.1256 (partial npm publish failure across lockstep packages), links the root-cause incident writeup, and calls out that the preflight script's lack of gitHead-aware skip logic is a real tooling gap worth a follow-up (without scope-creeping this PR to fix it).
  • Verification steps are stated and concrete: confirms 0.1.1257 sorts above both main's RC and npm latest so the release job won't no-op, deno task typecheck passes with no staleness warning, and notes this exact commit already has a fully-verified published RC build with matching gitHead.
  • Commit message and PR title are clear and match repo convention (release: vX.Y.Z).

Minor concerns:

  • CI is still pending on this snapshot (Automated review pending) and mergeable_state is blocked — nothing to fix in the diff itself, just confirm required checks are green before merging.
  • The follow-up fix for the preflight script's missing gitHead-aware skip logic is called out but not tracked with a linked issue — worth filing one so it doesn't get lost.

This is a mechanical release PR (docs/version-bump equivalent) — the above score reflects that category, not a feature change.


Generated by Claude Code

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The version bump is consistent across deno.json, VERSION, and the regenerated hydration bundle, aligning with the stated release intent.

Pull request overview

Promotes the repository version from 0.1.1257-rc to the stable 0.1.1257 so the release workflow publishes latest on npm for the lockstep packages.

Changes:

  • Bumped the package version in deno.json to 0.1.1257.
  • Updated the shared runtime VERSION constant to 0.1.1257.
  • Regenerated the prebundled hydration runtime so the embedded version string matches the stable release.

Verification noted in PR description: deno task typecheck (exit 0, no “is stale” output).

File summaries
File Description
deno.json Updates the package version to 0.1.1257 for the stable release.
src/utils/version-constant.ts Keeps the exported VERSION constant in sync with deno.json.
src/html/hydration-script-builder/hydration-runtime.generated.ts Regenerated hydration runtime bundle to embed VERSION = "0.1.1257".
Review details
  • Files reviewed: 2/3 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@gitar-bot

gitar-bot Bot commented Sep 5, 2026

Copy link
Copy Markdown

Note

Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime.
Learn more

Code Review ✅ Approved

Version bump from 0.1.1257-rc to 0.1.1257 to recover from a partial npm publish failure in v0.1.1256 by cutting forward instead of retrying. Updates deno.json, src/utils/version-constant.ts, and regenerated hydration script. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Important

Your trial ends in 4 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

Was this helpful? React with 👍 / 👎 | Gitar

@codecov

codecov Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@sonarqubecloud

sonarqubecloud Bot commented Sep 5, 2026

Copy link
Copy Markdown

@kwakayama
kwakayama enabled auto-merge September 5, 2026 00:32
@kwakayama

Copy link
Copy Markdown
Contributor Author

Gitar review

@gitar-bot

gitar-bot Bot commented Sep 5, 2026

Copy link
Copy Markdown

Gitar review

On it — running a review now.

@kwakayama
kwakayama added this pull request to the merge queue Sep 5, 2026
Merged via the queue into main with commit 62a2390 Sep 5, 2026
62 checks passed
@kwakayama
kwakayama deleted the release/v0.1.1257 branch September 5, 2026 01:09
@kojiwakayama kojiwakayama mentioned this pull request Sep 10, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants