release: v0.1.1257 - #4417
release: v0.1.1257#4417
Conversation
There was a problem hiding this comment.
kwakayama has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Warning Review limit reachedNext included review available in 19 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
📦 Client bundle boundary
A server module in a client graph aborts hydration in the browser. New leaks fail CI; known leaks are tracked in |
Code Review: Score 94/100 — ExcellentTrivial, well-justified release version-bump. Low risk, high care. Strengths:
Minor concerns:
This is a mechanical release PR (docs/version-bump equivalent) — the above score reflects that category, not a feature change. Generated by Claude Code |
There was a problem hiding this comment.
🟢 Approval recommended
The version bump is consistent across deno.json, VERSION, and the regenerated hydration bundle, aligning with the stated release intent.
Pull request overview
Promotes the repository version from 0.1.1257-rc to the stable 0.1.1257 so the release workflow publishes latest on npm for the lockstep packages.
Changes:
- Bumped the package version in
deno.jsonto0.1.1257. - Updated the shared runtime
VERSIONconstant to0.1.1257. - Regenerated the prebundled hydration runtime so the embedded version string matches the stable release.
Verification noted in PR description: deno task typecheck (exit 0, no “is stale” output).
File summaries
| File | Description |
|---|---|
| deno.json | Updates the package version to 0.1.1257 for the stable release. |
| src/utils/version-constant.ts | Keeps the exported VERSION constant in sync with deno.json. |
| src/html/hydration-script-builder/hydration-runtime.generated.ts | Regenerated hydration runtime bundle to embed VERSION = "0.1.1257". |
Review details
- Files reviewed: 2/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Note Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime. Code Review ✅ ApprovedVersion bump from OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Important Your trial ends in 4 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
|
Gitar review |
On it — running a review now. |



Promotes
mainfrom0.1.1257-rcto a clean0.1.1257so the release job publishes to npm--tag latest.Why this instead of retrying 0.1.1256
veryfront-code#4414 ("release: v0.1.1256") merged, but its npm publish partially failed: 2 of 6 lockstep packages (
@veryfront/ext-auth-jwt,@veryfront/ext-document-kreuzberg) published successfully; the other 4 (veryfrontitself,ext-observability-opentelemetry,ext-observability-sentry,ext-sandbox-shell-tools) never did. Cause: the publish script's 5-minute wait for npm registrygitHeadmetadata to propagate timed out onext-document-kreuzbergbefore it settled -- a registry-propagation false timeout, not a real conflict (itsgitHeadis correct now).A plain retry doesn't recover this: the release job's preflight step (
scripts/ci/publish-npm-packages.sh preflight) fails unconditionally on any package that already exists at the target version, with no gitHead-aware skip logic (confirmed by attempting it -- failed immediately on@veryfront/ext-auth-jwt@0.1.1256 already exists). That's a real gap in the release tooling worth a follow-up fix, but not one to make under this pressure.Cutting forward to
0.1.1257instead:0.1.1256becomes a harmless orphaned interior version (nothing ever pointedlatestat it, and npm versions are immutable anyway), matching this repo's own "no redeploy, cut forward" rollback philosophy.Files
Mirrors the v0.1.1256/v0.1.1255 releases:
deno.json,src/utils/version-constant.ts, and the regeneratedsrc/html/hydration-script-builder/hydration-runtime.generated.ts.templates/manifest.generated.tsneeded no change.Verified
0.1.1257is above bothmain(0.1.1257-rc) and npmlatest(0.1.1255), so the release job will not no-op.deno task typecheck-- exit 0, nois staleoutput.veryfront@0.1.1257-rc.18559,gitHeadconfirmed matching.Note
Full incident writeup: veryfront-infrastructure#331.