feat(agent): install executor profiles restricted to project tools by kojiwakayama · Pull Request #4477 · veryfront/veryfront-code

kojiwakayama · 2026-09-10T13:16:01Z

The executor currently installs a full agent runtime. Add an explicit project-tools profile that installs only fixed project context, a bounded canonical tool allowlist, and call limits. It exposes discovery and project-tool operations, while excluding runtime preparation, agent streaming, and privileged host capability fields.

Reuse the one-shot installation gate and fixed-image owner/source binding. The selected profile and installer callback are captured before project code loads. Project discovery inherits the original installation deadline, and project resources remain owned until tool handlers finish after cancellation. The default runtime profile is preserved.

Validation: 40 focused installation/runtime/broker test steps passed; changed-file typecheck, lint, formatting, layout, anti-slop, and generated API-reference checks passed. Independent static review found no actionable issues. The existing fixed-port Node entrypoint fixture now tests both profiles in the same serialized suite, including actual project loading, allowed tool execution, and rejected full-runtime operations; native execution remains for CI.

Stacked on #4476. This component does not switch traffic or activate the allocator. Broker-local trusted runtime composition and staging verification remain required.

Part of https://github.com/veryfront/veryfront-issue-inbox/issues/367 and https://github.com/veryfront/veryfront-issue-inbox/issues/1037.

Summary by CodeRabbit

New Features
- Added a project-tools installation profile alongside the default runtime profile.
- Project-tools installations expose fixed-context project tool discovery and execution with configurable tool, call, and concurrency limits.
- Added validation for project-tool configuration, bindings, permissions, and installation profiles.
Documentation
- Updated executor runtime documentation to explain both installation profiles, their capabilities, and configuration requirements.
Tests
- Added coverage for project-tool installation, validation, execution, cleanup, cancellation, and profile selection.

coderabbitai · 2026-09-10T13:16:12Z

Warning

Review limit reached

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 35004264-54d2-41e0-81ac-4afa61f7065a

📥 Commits

Reviewing files that changed from the base of the PR and between 0ad9423 and d816943.

📒 Files selected for processing (10)

docs/guides/agent-service-runtime.md
src/agent/hosted/executor-project-runtime.test.ts
src/agent/hosted/executor-project-runtime.ts
src/agent/hosted/executor-project-tools.ts
src/agent/hosted/executor-runtime-prepare.test.ts
src/agent/hosted/executor-runtime-prepare.ts
src/agent/project/agent-runtime.test.ts
src/agent/project/agent-runtime.ts
src/discovery/agent-scoped-capabilities.test.ts
src/discovery/agent-scoped-capabilities.ts

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: ef139169-1f00-4ca4-928e-a1308100dbbc

📥 Commits

Reviewing files that changed from the base of the PR and between 0025748 and 0ad9423.

📒 Files selected for processing (11)

docs/api-reference/veryfront/agent.md
docs/guides/agent-service-runtime.md
src/agent/hosted/executor-project-install.test.ts
src/agent/hosted/executor-project-runtime.test.ts
src/agent/hosted/executor-project-runtime.ts
src/agent/hosted/executor-runtime-entrypoint-options.test.ts
src/agent/hosted/executor-runtime-entrypoint.ts
src/agent/hosted/executor-runtime-install-schema.ts
src/agent/hosted/executor-runtime-install.ts
tests/fixtures/executor-runtime-process.ts
tests/integration/agent/executor-runtime-entrypoint.fixture.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The executor runtime now supports runtime and project-tools profiles. The project-tools profile validates fixed project context, exposes discovery and tool operations, enforces limits, and retains resources during active tool streams. Entrypoint, integration tests, unit tests, and documentation cover both profiles.

Changes

Project-tools executor profile

Layer / File(s)	Summary
Installation contract and operation modes `src/agent/hosted/executor-runtime-install-schema.ts`, `src/agent/hosted/executor-runtime-install.ts`, `src/agent/hosted/executor-project-install.test.ts`	Adds the `project-tools` installation schema, limits, operation map, discriminated installation options, and profile-specific install handling. Tests validate accepted operations and rejected inputs.
Project-tool runtime construction `src/agent/hosted/executor-project-runtime.ts`, `src/agent/hosted/executor-project-runtime.test.ts`	Adds project discovery validation, fixed context capture, allowed-tool enforcement, call and concurrency limits, stream retention, and cleanup behavior.
Entrypoint profile routing and validation `src/agent/hosted/executor-runtime-entrypoint.ts`, `src/agent/hosted/executor-runtime-entrypoint-options.test.ts`, `tests/fixtures/executor-runtime-process.ts`, `tests/integration/agent/executor-runtime-entrypoint.fixture.ts`	Routes trusted startup modes to separate runtime paths. Invalid modes fail before bootstrap access. Integration coverage runs both profiles and verifies project tool listing and execution.
Profile behavior documentation `docs/api-reference/veryfront/agent.md`, `docs/guides/agent-service-runtime.md`	Documents profile selection, installation fields, context binding, limits, available operations, and project-tools restrictions.

Estimated code review effort: 4 (Complex) | ~45 minutes

Merge Risk: ⚪ Minimal · up to 0ad94

The profile boundaries, validation, restricted operations, and cleanup behavior are covered without an identified merge-blocking issue.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 9 files. (2 skipped: 2…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the primary change: adding executor installation profiles with a project-tools restriction.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 9 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/project-tools-executor-install

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-09-10T13:16:22Z

📦 Client bundle boundary

Entrypoint	Modules	Source size	Server leaks
`src/index.client.ts`	289	2307 KiB	✅ 0

A server module in a client graph aborts hydration in the browser. New leaks fail CI; known leaks are tracked in scripts/lint/client-bundle-baseline.json to burn down.

…ools-executor-install

gitar-bot · 2026-09-10T13:17:43Z

Gitar is working

_Gitar

codecov · 2026-09-10T13:26:44Z

Codecov Report

❌ Patch coverage is 78.23129% with 64 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/agent/hosted/executor-runtime-entrypoint.ts	4.83%	56 Missing and 3 partials ⚠️
src/agent/hosted/executor-runtime-install.ts	91.11%	2 Missing and 2 partials ⚠️
src/agent/hosted/executor-project-runtime.ts	99.10%	0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

greptile-apps

Your trial has ended. Reactivate Greptile to resume code reviews.

github-actions · 2026-09-10T13:31:41Z

@codex review

chatgpt-codex-connector · 2026-09-10T13:35:04Z

Codex Review: Didn't find any major issues. 👍

Reviewed commit: a2c1e0855c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…ry' into feat/project-tools-executor-install

greptile-apps

Your trial has ended. Reactivate Greptile to resume code reviews.

github-actions · 2026-09-10T14:48:20Z

@codex review

…gent-delivery

chatgpt-codex-connector · 2026-09-10T14:52:38Z

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 3ec1daf750

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…ry' into feat/project-tools-executor-install

greptile-apps

Your trial has ended. Reactivate Greptile to resume code reviews.

github-actions · 2026-09-10T14:57:17Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3c7b55041e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

greptile-apps

Your trial has ended. Reactivate Greptile to resume code reviews.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 40743f993a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

github-actions · 2026-09-10T15:11:05Z

@codex review

chatgpt-codex-connector · 2026-09-10T15:11:41Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

greptile-apps

Your trial has ended. Reactivate Greptile to resume code reviews.

github-actions · 2026-09-10T18:12:47Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c2cdbd3a03

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

greptile-apps

Your trial has ended. Reactivate Greptile to resume code reviews.

github-actions · 2026-09-10T18:32:34Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 141da2783a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

kwakayama · 2026-09-10T18:45:16Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 141da2783a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

kwakayama · 2026-09-10T19:04:39Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 141da2783a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

kwakayama · 2026-09-10T19:33:55Z

@codex review. Please review exact head 141da27; if there are no actionable findings, report the clean verdict.

chatgpt-codex-connector · 2026-09-10T19:38:37Z

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 141da2783a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

greptile-apps

Your trial has ended. Reactivate Greptile to resume code reviews.

github-actions · 2026-09-10T19:42:32Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3a5a9814d4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

greptile-apps

Your trial has ended. Reactivate Greptile to resume code reviews.

github-actions · 2026-09-10T19:50:13Z

@codex review

chatgpt-codex-connector · 2026-09-10T19:55:07Z

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: d816943fad

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

sonarqubecloud · 2026-09-10T20:03:58Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
85.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

kojiwakayama added 2 commits September 10, 2026 15:01

feat(agent): prepare trusted runtimes with isolated project tools

dc26c9e

feat(agent): install executor profiles restricted to project tools

87c7875

kojiwakayama added 2 commits September 10, 2026 15:16

test(agent): make native fixture field ordering explicit

e576e6a

Merge branch 'feat/trusted-hosted-agent-delivery' into feat/project-t…

a2c1e08

…ools-executor-install

kojiwakayama marked this pull request as ready for review September 10, 2026 13:31

kojiwakayama requested a review from kwakayama as a code owner September 10, 2026 13:31

greptile-apps Bot reviewed Sep 10, 2026

View reviewed changes

kojiwakayama mentioned this pull request Sep 10, 2026

feat(agent): keep trusted runtimes in the managed broker #4478

Merged

kojiwakayama added 3 commits September 10, 2026 16:45

fix(agent): derive project tool run authority from execution kind

17db73f

Merge remote-tracking branch 'origin/feat/trusted-hosted-agent-delive…

8c7df56

…ry' into feat/project-tools-executor-install

fix(agent): bind installed project tools to canonical execution

3ec1daf

greptile-apps Bot reviewed Sep 10, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into feat/trusted-hosted-a…

92e432f

…gent-delivery

Merge remote-tracking branch 'origin/feat/trusted-hosted-agent-delive…

3c7b550

…ry' into feat/project-tools-executor-install

greptile-apps Bot reviewed Sep 10, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Sep 10, 2026

View reviewed changes

Comment thread src/agent/hosted/executor-project-runtime.ts Outdated

Comment thread src/agent/hosted/executor-runtime-entrypoint.ts

test(agent): use explicit execution kind in native project fixture

40743f9

greptile-apps Bot reviewed Sep 10, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Sep 10, 2026

View reviewed changes

Comment thread src/agent/hosted/executor-project-runtime.ts

style(agent): format project runtime regression

c2cdbd3

greptile-apps Bot reviewed Sep 10, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Sep 10, 2026

View reviewed changes

Comment thread src/agent/hosted/executor-project-runtime.ts Outdated

fix(agent): scope inline project tools to selected agent

141da27

greptile-apps Bot reviewed Sep 10, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Sep 10, 2026

View reviewed changes

Comment thread src/agent/hosted/executor-project-runtime.ts Outdated

chatgpt-codex-connector Bot reviewed Sep 10, 2026

View reviewed changes

Comment thread src/agent/hosted/executor-project-runtime.ts Outdated

chatgpt-codex-connector Bot reviewed Sep 10, 2026

View reviewed changes

Comment thread src/agent/hosted/executor-project-runtime.ts Outdated

fix(agent): build isolated project catalogs under source policy

3a5a981

greptile-apps Bot reviewed Sep 10, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Sep 10, 2026

View reviewed changes

Comment thread src/agent/hosted/executor-runtime-prepare.ts Outdated

fix(agent): scope full runtime inline tools to project policy

d816943

greptile-apps Bot reviewed Sep 10, 2026

View reviewed changes

kwakayama added this pull request to the merge queue Sep 10, 2026

kwakayama removed this pull request from the merge queue due to a manual request Sep 10, 2026

kwakayama added this pull request to the merge queue Sep 10, 2026

Merged via the queue into main with commit 5618a35 Sep 10, 2026
60 checks passed

kwakayama deleted the feat/project-tools-executor-install branch September 10, 2026 20:48

kojiwakayama mentioned this pull request Sep 10, 2026

feat(agent): execute direct durable and AG-UI broker requests #4479

Merged

6 tasks done

Conversation

kojiwakayama commented Sep 10, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Client bundle boundary

Uh oh!

gitar-bot Bot commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 10, 2026

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 10, 2026

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

github-actions Bot commented Sep 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 10, 2026

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

kojiwakayama commented Sep 10, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 10, 2026 •

edited

Loading

github-actions Bot commented Sep 10, 2026 •

edited

Loading

gitar-bot Bot commented Sep 10, 2026 •

edited

Loading

codecov Bot commented Sep 10, 2026 •

edited

Loading