feat(agent): name the accepting replica on hosted run starts by kojiwakayama · Pull Request #4500 · veryfront/veryfront-code

kojiwakayama · 2026-09-16T11:30:19Z

Why

A hosted agent service keeps each detached run's session in the memory of the replica that accepted the start. Run control for that run (cancel, resume) only works on that replica. Starts usually arrive through a load-balanced address, so a later control request through the same address can land on a replica without the session and do nothing. With two replicas, a cancellation sent through the shared address missed its run in 2 of 5 cases.

The project agent-stream route already solves this: it names its replica in x-veryfront-runtime-owner-invoke-url so the caller can reach it again. The hosted default-chat start route (POST /api/runs) did not.

What changes

createHostedAgentServiceRouteSet accepts an optional resolveRuntimeOwnerInvokeUrl(request). It defaults to the existing resolver in src/internal-agents/runtime-owner.ts (VERYFRONT_RUNTIME_OWNER_HOST, POD_IP, or a network interface).
handleDurableChatRunExecuteRequest adds x-veryfront-runtime-owner-invoke-url when it accepts a start (202).
Nothing changes for any other response. A resolver that throws or returns nothing also leaves the accepted response as it was, since the run is accepted either way and control keeps using the shared address.

The advertised URL keeps the resolver's existing shape, the same value the agent-stream route sends. A caller uses its origin to reach the replica.

Tests

an accepted default-chat start names the replica that accepted it
a rejected start (401) names none
an accepted start is unaffected when the replica address cannot be resolved

The route-set test factory defaults the resolver to null, so existing tests do not depend on the host's network interfaces. deno check, deno fmt --check, deno lint, every src/agent/service test suite, and docs:api-reference:check pass.

https://claude.ai/code/session_01NonPHDcbWsisd2GFB68ALo

Summary by CodeRabbit

New Features
- Durable chat start responses can now include the runtime owner’s invocation URL when available.
Bug Fixes
- Unauthenticated requests and cases where the runtime owner URL cannot be resolved no longer advertise a replica URL.
- Chat starts continue returning a successful response even when runtime owner resolution fails.

A hosted agent service keeps a detached run's session in the memory of the replica that accepted the start, and run control only works there. Starts arrive through a load-balanced address, so a later cancel through the same address can reach a replica without the session. The hosted default-chat start now adds x-veryfront-runtime-owner-invoke-url when it accepts a run, as the project agent-stream route already does, so the caller can reach that replica. Claude-Session: https://claude.ai/code/session_01NonPHDcbWsisd2GFB68ALo

kojiwakayama · 2026-09-16T11:30:21Z

@codex review

chatgpt-codex-connector · 2026-09-16T11:30:25Z

You have reached your Codex usage limits for security reviews. Please try again later.

greptile-apps

Your trial has ended. Reactivate Greptile to resume code reviews.

coderabbitai · 2026-09-16T11:30:40Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 4b14e04e-662c-452f-ae5c-e21619441a2c

📥 Commits

Reviewing files that changed from the base of the PR and between 94e5463 and 265ab1f.

📒 Files selected for processing (2)

src/agent/service/routes.test.ts
src/agent/service/routes.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The route set now resolves a runtime-owner URL for accepted durable-chat starts and returns it in a response header. Tests cover successful resolution, unauthenticated requests, and resolver failures.

Changes

Runtime-owner URL handling

Layer / File(s)	Summary
Resolver option and test wiring `src/agent/service/routes.ts`, `src/agent/service/routes.test.ts`	The route set adds an optional `resolveRuntimeOwnerInvokeUrl` callback. Tests wire the callback and default it to a null result.
Accepted-start response handling `src/agent/service/routes.ts`, `src/agent/service/routes.test.ts`	A resolved URL is added to accepted `202` responses. Non-`202` responses, null results, and resolver failures omit the header. Tests cover these cases.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant Client
  participant DurableChatRoute
  participant RuntimeOwnerResolver
  Client->>DurableChatRoute: POST /api/runs
  DurableChatRoute->>RuntimeOwnerResolver: Resolve runtime-owner URL
  RuntimeOwnerResolver-->>DurableChatRoute: URL or no URL
  DurableChatRoute-->>Client: 202 response with optional runtime-owner header

Merge Risk: ⚪ Minimal · up to 265ab

The accepted-start header behavior has no established merge-blocking risk in the supplied implementation context.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: advertising the accepting replica for hosted run starts.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Fix all pre-merge checks with AI

✨ Finishing Touches 💡 2

📝 Generate docstrings 💡

Create stacked PR
Commit on current branch

🛠️ Fix failing CI checks 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/hosted-run-start-advertises-owner

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-09-16T11:30:42Z

📦 Client bundle boundary

Entrypoint	Modules	Source size	Server leaks
`src/index.client.ts`	289	2307 KiB	✅ 0

A server module in a client graph aborts hydration in the browser. New leaks fail CI; known leaks are tracked in scripts/lint/client-bundle-baseline.json to burn down.

gitar-bot · 2026-09-16T11:30:57Z

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

_Gitar

kojiwakayama · 2026-09-16T11:31:09Z

@codex review

chatgpt-codex-connector · 2026-09-16T11:36:05Z

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 265ab1fda2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-09-16T11:39:30Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

sonarqubecloud · 2026-09-16T11:43:06Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

kojiwakayama requested a review from kwakayama as a code owner September 16, 2026 11:30

greptile-apps Bot reviewed Sep 16, 2026

View reviewed changes

kojiwakayama added this pull request to the merge queue Sep 16, 2026

Merged via the queue into main with commit 7c47cc6 Sep 16, 2026
67 checks passed

kojiwakayama deleted the feat/hosted-run-start-advertises-owner branch September 16, 2026 13:40

kojiwakayama mentioned this pull request Sep 16, 2026

release: veryfront 0.1.1259 #4501

Merged

3 tasks

Navigation Menu

feat(agent): name the accepting replica on hosted run starts - #4500

feat(agent): name the accepting replica on hosted run starts#4500
kojiwakayama merged 1 commit into
mainfrom
feat/hosted-run-start-advertises-owner

kojiwakayama commented Sep 16, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

kojiwakayama commented Sep 16, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 16, 2026

Uh oh!

greptile-apps Bot left a comment

Uh oh!

coderabbitai Bot commented Sep 16, 2026 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Sep 16, 2026

Uh oh!

gitar-bot Bot commented Sep 16, 2026

Uh oh!

kojiwakayama commented Sep 16, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 16, 2026

Uh oh!

codecov Bot commented Sep 16, 2026

Uh oh!

sonarqubecloud Bot commented Sep 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

kojiwakayama commented Sep 16, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

What changes

Tests

Summary by CodeRabbit

Uh oh!

kojiwakayama commented Sep 16, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 16, 2026

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot commented Sep 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Sep 16, 2026

📦 Client bundle boundary

Uh oh!

gitar-bot Bot commented Sep 16, 2026

Uh oh!

kojiwakayama commented Sep 16, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 16, 2026

Uh oh!

codecov Bot commented Sep 16, 2026

Codecov Report

Uh oh!

sonarqubecloud Bot commented Sep 16, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

kojiwakayama commented Sep 16, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 16, 2026 •

edited

Loading