feat(core): add structured error diagnostics - #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ErrorKindclassification and an ownedDiagnosticcontext wrapper while preserving the existing allocation-freeErrorvariantsTop-down scope
gamut-core::Error,ErrorKind, andDiagnostic, re-exported throughgamut::coreAV2 and VVC remain declaration-only stubs. The dependency-free codec ABI and separate metadata error domains stay unchanged except where XMP converts into the core error type. CLI and WASM behavior are outside this change.
Compatibility
The three legacy variants remain source-compatible and allocation-free. Structured context is additive through the non-exhaustive
Contextvariant; decorators are first-write-wins and preserve the source chain.Validation
mise run fmt-checkmise run lintmise run testmise run coverage— 97.22% linesmise run check-msrvmise run check-ffimise run check-ffi-featuresmise run check-ffi-headermise run check-ffi-seamsmise run check-release-depsmise run check-commitsCloses #254