chore(tests,bench): fixtures and benchmark final pass for the gamut migration - #56
Merged
Merged
Conversation
…igration TEST_FIXTURES.md records the post-migration reality: which gamut backends replaced which deleted ones, that encoder bytes changed, the corrected test invocation list (tiff_parser_tests is gone; ifd_decoder_tests and the hw decode suites are in), and the locally generated HEIC fixture. fixtures.json needed no change. The three stray root images (untracked personal files with zero code references) moved into the gitignored test_fixtures/. Benches: decode.rs gains JPEG and PNG encode+decode round-trip benches on the gamut backends — the first benches that exercise codecs — plus gated HEIC and AVIF hardware-decode benches that self-generate fixtures via heif-enc/avifenc and skip cleanly without the tools or a GPU. cargo bench --no-run passes on default and full features. Pre-migration baselines were never captured; that is recorded honestly rather than invented (per-codec before/after numbers live in the PNG and JPEG migration PRs). docs/BENCHMARKS.md stores the post-migration --quick baseline from this host (Ryzen 7 7800X3D + RX 7900 VAAPI): jpeg 6.5/6.0 ms encode/ decode at 512x512, png 23.0/4.7 ms, heic and avif hardware decode 9.2/9.5 ms on the real GPU, amaze demosaic 199.5 ms at 2000x2000. Example coverage verified per the AGENTS.md methodology: all eight examples build and run with full features — every migrated format is exercised, with HEIC hardware-decoding live and AVIF failing only on the documented profile-1/VAAPI-scope gate (gamut#303 territory). The malformed-TIFF corpus from the deleted binrw parser tests (11 hostile cases + 2 robustness cases, reconstructed from git history) is contributed upstream on visualcommons/gamut#264 per the issue.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35.
Stacked on #55; merge order #42 → … → #55 → this.
What is Delivered
fixtures.jsonaudited — no change needed. Stray root images (IMG_1347.jpg,_JIC7790.jpeg,test.jpeg— untracked, zero references) moved into gitignoredtest_fixtures/.cargo bench --no-rungreen on default + full.docs/BENCHMARKS.mdrecords the going-forward--quickbaseline from this host, including real-GPU HEIC (9.2 ms) and AVIF (9.5 ms) hardware decode.full— every migrated format exercised end-to-end (ARW→JPEG develop, DNG→PNG export, live hardware HEIC decode; AVIF hits only the documented profile-1 scope gate).Verification Done
Run independently:
cargo test --workspace387/0;--features full563/0; bench compile clean both configs; clippy-D warnings0; root images gone from the repo root and present intest_fixtures/. lefthook green.