test: cover negative fixed float interpolation - #28904
Merged
Merged
Conversation
antono3
force-pushed
the
fix/v3-negative-float-format
branch
from
September 26, 2026 05:24
b68ced5 to
d6070ec
Compare
medvednikov
reviewed
Sep 30, 2026
medvednikov
left a comment
Member
There was a problem hiding this comment.
Reviewed current head d6070ecfec9a4c36d31c4eb1c92febde70a372c2; no concrete correctness issue found in the two added assertions.
Both f32 and f64 are explicitly exercised, and exact fixed-format string comparisons check the negative sign as well as the three decimal places. The chosen values are not halfway rounding cases at that precision, so the assertions isolate sign preservation rather than introducing an ambiguous rounding expectation. This head is test-only; the existing half-away-from-zero cases are retained.
Static test review only; I did not execute the test here, and CI results were not used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retain exact negative
f32andf64fixed-format interpolation regressions. The implementation fix (signbit(x) != 0) already landed on master in e814006; this refreshed PR is test-only.Current-master verification (2026-09-26)
Rebased onto
6c359c228241b44f9d9a942696e83b513931e532. The focused regression passes with strict V3 (-new-compiler). It also passes on unmodified master; this PR preserves regression coverage. Formatting verification for all changed V files andgit diff --checkpass. The previously failing twelve formatter files pass on this master. The unrelatedanon_struct_cross_module_init_test.vstill fails on unmodified master (the genuinely anonymous parameter case); this refresh does not change it.