Skip to content

fix: parquet negative DECIMAL loses sign (Issue #234) - #243

Merged
vmvarela merged 1 commit into
masterfrom
fix/parquet-decimal-sign-234
Sep 12, 2026
Merged

vmvarela merged 1 commit into
masterfrom
fix/parquet-decimal-sign-234

Conversation

@vmvarela

Copy link
Copy Markdown
Owner

Closes #234.

What: signo independiente en decimalToText@divTrunc(value,pow10)==0 con value<0 emitía "0.01" en vez de "-0.01". Aritmética en magnitud unsigned, '-' prefijado, reusa intToBuf.

  • src/parquet.zig: fix + primer unit test del fichero (5 asserts).
  • build.zig: target parquet_unit_tests en unit-test (espejo loader) — sin esto el test nunca corría en CI.

Test:

  • Control negativo: test falla sin fix (85/86).
  • zig build unit-test y zig build test exit 0.

@github-actions github-actions Bot added the type:bug Something isn't working label Sep 12, 2026
@vmvarela
vmvarela merged commit f41d2ee into master Sep 12, 2026
5 checks passed
@vmvarela
vmvarela deleted the fix/parquet-decimal-sign-234 branch September 12, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Parquet negative DECIMAL loses its sign (silent data corruption)

1 participant