bottom: update to 0.8.0. - #43212
Merged
Merged
Conversation
20 tasks
jcgruenhage
marked this pull request as draft
April 2, 2023 19:27
jcgruenhage
force-pushed
the
bottom-0.8.0_1
branch
from
April 3, 2023 07:05
065f92b to
d14dfde
Compare
jcgruenhage
marked this pull request as ready for review
April 3, 2023 07:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
When building locally, this failed due to dependency resolution problems, which are caused by our inconsistent use of the
--lockedand--offlineflags for cargo. Once we've got #43233 in, this will build just fine though.EDIT: heh, I'm confused. Now this built just fine in CI without
--locked, maybe this was just a random local failure.