Skip to content

fix(storage): honour VOUCH_KB_PATH env var in discover_root - #144

Merged
plind-junior merged 2 commits into
testfrom
fix/vouch-kb-path
Jun 1, 2026
Merged

fix(storage): honour VOUCH_KB_PATH env var in discover_root#144
plind-junior merged 2 commits into
testfrom
fix/vouch-kb-path

Conversation

@plind-junior

Copy link
Copy Markdown
Member

the var was already documented in adapters/generic-mcp/README ('force a specific KB root, skip discovery') but never wired into the code. now discover_root() reads VOUCH_KB_PATH first and short-circuits the upward walk, with a clear error if the value isn't an existing .vouch directory.

closes the doc-vs-code drift and removes the per-host 'cwd: ...' ceremony needed by Claude Desktop (and any other host that launches the stdio server from a default working directory).

What changed

Why

What might break

VEP

Tests

  • make check passes locally (lint + mypy + pytest)
  • New / changed behaviour has a test
  • CHANGELOG.md updated under ## [Unreleased]

the var was already documented in adapters/generic-mcp/README ('force a
specific KB root, skip discovery') but never wired into the code. now
`discover_root()` reads VOUCH_KB_PATH first and short-circuits the upward
walk, with a clear error if the value isn't an existing .vouch directory.

closes the doc-vs-code drift and removes the per-host 'cwd: ...' ceremony
needed by Claude Desktop (and any other host that launches the stdio
server from a default working directory).
@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: bbd1eb70-60b1-42af-9b61-3722513f39cc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/vouch-kb-path

Comment @coderabbitai help to get the list of available commands and usage tips.

@plind-junior
plind-junior changed the base branch from main to test June 1, 2026 08:00
@plind-junior
plind-junior merged commit e6f6b54 into test Jun 1, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant