fix(install): self-heal a broken fallback pipx, mktemp for logs (#370 review) - #371
Merged
Merged
Conversation
two #370 review findings: - a leftover ~/.local/bin/pipx shim whose private venv died (e.g. a brew python upgrade) passed the has_cmd probe, so re-runs accepted the corpse as installed and never reached the recreation path. require a working `pipx --version` before returning early; verified end-to-end by breaking the venv and re-running. - the install log used a predictable /tmp path, which a pre-created symlink could redirect over a user-writable file. mktemp instead.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses the two coderabbit findings on #370: a broken fallback pipx (dead private venv after e.g. a brew python upgrade) is no longer accepted by the has_cmd probe — a working
pipx --versionis required before the early return, and re-runs fall through to the recreation path (verified end-to-end by breaking the venv and re-running); and the pipx install log now comes from mktemp instead of a predictable /tmp path.