fix(lint): exempt retired claims from stale check - #484
Merged
plind-junior merged 1 commit intoJul 15, 2026
Conversation
vouch lint was the odd one out: metrics.py and digest.py both already exempt retired statuses (superseded/archived/redacted) from their stale checks, with comments explicitly describing this as lint's intended behaviour. This makes lint consistent with its siblings. Closes vouchdev#478
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
luciferlive112116
added a commit
to luciferlive112116/vouch
that referenced
this pull request
Jul 15, 2026
the fix landed in vouchdev#484 without a changelog entry, and the `## [Unreleased]` / `### Fixed` section is what the next release notes are rolled from — a user-visible behaviour change (lint stops emitting `stale_claim` warnings for retired claims) would otherwise ship undocumented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vouch lintwas the odd one out:metrics.pyanddigest.pyboth already exempt retired statuses (superseded/archived/redacted) from their stale checks, with comments explicitly describing this as lint's intended behaviour. Lint was running the stale check over every claim with no status guard, producingstale_claimwarnings for retired claims — non-actionable noise since retired claims are terminal and not expected to be refreshed.Changes
_RETIRED_CLAIM_STATUSEStohealth.py(mirrors the constant indigest.pyand the local set inmetrics.py)lint()withif c.status not in _RETIRED_CLAIM_STATUSESRepro
Register a source, add an
archivedclaim whoseupdated_atis older than the freshness window (e.g. 400 days).vouch lintemits astale_claimfinding;vouch metricsandvouch digestdo not.Closes #478