fix: keep mindmodel constraint files on the .md extension (#58) - #99
Open
vtemian wants to merge 1 commit into
Open
fix: keep mindmodel constraint files on the .md extension (#58)#99vtemian wants to merge 1 commit into
vtemian wants to merge 1 commit into
Conversation
/mindmodel sometimes emitted stack/frontend.yaml instead of .md. The generator prompt only implied the rule through its directory listing, so weaker models read manifest.yaml as licence to write every file as YAML. State the rule outright, and have the loader name any category path that is not .md. The manifest still loads: a wrong extension leaves the directory inconsistent rather than broken, so it does not justify discarding the whole mindmodel. Closes #58
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #58.
Problem
/mindmodelgenerated constraint files ending in.yamlinstead of.md. Reported against qwen3.6 35b.The generator prompt was not actually wrong, which is why this is easy to miss: its
<output-structure>block lists every constraint file with a.mdextension and onlymanifest.yamlas YAML. But the rule was only ever implied by that listing. Sitting right beside it is a<manifest-format>block containing ayamlcode fence, and a weaker model reads that as licence to write the whole directory as YAML.Fix
Two parts, because prompt wording alone is not verifiable.
Say the rule outright.
<rules>now states thatmanifest.yamlis the only YAML file and names the exact mistake, rather than leaving it to be inferred from a directory diagram.Report it when it happens anyway. The loader now names any category path that is not
.md:Deliberately a warning, not a parse failure. A wrong extension leaves the directory inconsistent rather than broken, since the file still loads by its declared path. Failing the manifest would discard an otherwise usable mindmodel over a naming problem, and the project's own guidance is to treat parse issues as non-fatal where possible.
Verification
490 tests pass (was 488). Two new cases: one asserting the warning names only the offending paths while the manifest still loads with all three categories intact, one asserting silence when every path is
.md.Mutation-checked: removing the
warnNonMarkdownCategoriescall fails the first test.The prompt change itself is not testable here, since it depends on model behaviour. The loader warning is what makes a bad generation visible rather than silent.