Skip to content

fix(client): improve render code accessibility - #1146

Open
vansh-nagar wants to merge 2 commits into
vuejs:mainfrom
vansh-nagar:fix-885-confirmation-dialog-accessibility
Open

vansh-nagar wants to merge 2 commits into
vuejs:mainfrom
vansh-nagar:fix-885-confirmation-dialog-accessibility

Conversation

@vansh-nagar

Copy link
Copy Markdown
Contributor

Summary

Improves keyboard and screen-reader behavior for the Render Code overlay in the Components inspector.

  • exposes the overlay as a labelled dialog
  • moves focus to the close action when the overlay opens
  • closes the overlay with Escape
  • restores focus to the invoking control when the overlay unmounts
  • adds an integration test covering semantics, focus, Escape, and focus restoration

Relates to #885.

Validation

  • pnpm vitest run tests/integration/client/render-code.test.ts
  • pnpm typecheck
  • pnpm lint
  • pnpm format:check
  • pnpm --filter @vue/devtools-client build

The local pre-commit dependency check could not run fully offline because one tarball was absent from the pnpm store; the same lint and formatting commands enforced by the hook were run directly and passed.

@netlify

netlify Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit b68761d
🔍 Latest deploy log https://app.netlify.com/projects/vue-devtools-docs/deploys/6ab6cb37917b440008d77f19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants