Skip to content

feat: detect the theme storage key of vitepress - #207

Closed
LoTwT wants to merge 9 commits into
vuejs:mainfrom
LoTwT:theme
Closed

LoTwT wants to merge 9 commits into
vuejs:mainfrom
LoTwT:theme

Conversation

@LoTwT

@LoTwT LoTwT commented Jan 29, 2024

Copy link
Copy Markdown
Contributor

description

This PR is to close #202.

It detects the theme storage key vitepress-theme-appearance. If the key is used in the local storage, it will be passed to useColorMode.

question

Should the default key vueuse-color-scheme be synchronized with the vitepress-theme-appearance in a vitepress project?

@netlify

netlify Bot commented Jan 29, 2024 •

Copy link
Copy Markdown

✅ Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit 3727bab
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/65eed66d04abf000088d978a

@autofix-troubleshooter

Copy link
Copy Markdown

Hi! I'm the autofix logoautofix.ci troubleshooter bot.

It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃

@LoTwT LoTwT changed the title fix(client): detect the theme storage key of vitepress feat: detect the theme storage key of vitepress Mar 1, 2024
@webfansplz
webfansplz requested a review from alexzhang1030 March 1, 2024 10:47
Comment thread packages/ui/src/composables/theme.ts Outdated
Comment thread packages/ui/src/composables/theme.ts
@alexzhang1030

Copy link
Copy Markdown
Member

You should rebase main branch to fix the conflicts

@LoTwT
LoTwT force-pushed the theme branch 2 times, most recently from b174a4f to 67c991f Compare March 5, 2024 01:20
@LoTwT
LoTwT requested a review from alexzhang1030 March 11, 2024 10:02
@webfansplz

Copy link
Copy Markdown
Member

Thanks for the PR, but I think it's too special and out of scope for the devtools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] appearance/theme can't consist with vitepress

5 participants