Skip to content

fix(simd): update SIMD opcodes#92

Merged
bmeurer merged 1 commit into
wasdk:masterfrom
ngzhian:update-simd
Mar 4, 2021
Merged

fix(simd): update SIMD opcodes#92
bmeurer merged 1 commit into
wasdk:masterfrom
ngzhian:update-simd

Conversation

@ngzhian

@ngzhian ngzhian commented Mar 2, 2021

Copy link
Copy Markdown
Contributor

See WebAssembly/simd#452 for finalized opcodes
and WebAssembly/simd#467 for some renamings.

@ngzhian

ngzhian commented Mar 2, 2021

Copy link
Copy Markdown
Contributor Author

Where do the .wasm files in __fixtures__ come from? Some of them need to be updated. I'm still running the tests and updating snapshot, will rebase later.

@bmeurer

bmeurer commented Mar 3, 2021

Copy link
Copy Markdown
Collaborator

Where do the .wasm files in __fixtures__ come from? Some of them need to be updated. I'm still running the tests and updating snapshot, will rebase later.

Those are generated by jest. You can pass -u to jest to rebaseline them.

@yurydelendik

yurydelendik commented Mar 3, 2021

Copy link
Copy Markdown
Collaborator

fixes #90

We probably want to disable some wabt tests. wasmparser.rs disables (until tools settle): simd_boolean.wast, simd_lane.wast, simd_i16x8_arith2.wast, simd_f64x2_rounding.wast, simd_f32x4_rounding.wast.

See WebAssembly/simd#452 for finalized opcodes
and WebAssembly/simd#467 for some renamings.
@ngzhian

ngzhian commented Mar 3, 2021

Copy link
Copy Markdown
Contributor Author

Updated with some tests disabled.

@ngzhian

ngzhian commented Mar 4, 2021

Copy link
Copy Markdown
Contributor Author

It looks like I can't merge this, please help me :) thanks!

@bmeurer
bmeurer merged commit 648fff5 into wasdk:master Mar 4, 2021
@bmeurer

bmeurer commented Mar 4, 2021

Copy link
Copy Markdown
Collaborator

Done, thanks!

@yurydelendik

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ngzhian
ngzhian deleted the update-simd branch March 4, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants