Skip to content

fix: repair public-variant foundation-gate (0-jobs workflow error) - #16

Merged
yakimoto merged 1 commit into
mainfrom
fix/foundation-gate-public-template
Jul 20, 2026
Merged

fix: repair public-variant foundation-gate (0-jobs workflow error)#16
yakimoto merged 1 commit into
mainfrom
fix/foundation-gate-public-template

Conversation

@yakimoto

@yakimoto yakimoto commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Root cause: foundation-gate.yml called the PRIVATE reusable wave-av/wave-foundation/.github/workflows/checks.yml@v1 from this PUBLIC repo. GitHub Actions does not permit a public repo to consume a private repo's reusable workflow, so the run failed in 0s with 0 jobs on every PR/push — restores the baseline CI gate to actually run.

Vendors _checks.yml (mirrors wave-foundation/checks.yml@v1) and points foundation-gate.yml at it via uses: ./.github/workflows/_checks.yml with job id gate, matching the known-good public-adopter pattern used by wave-moq-edge, dispatch-edge, adk, and others.


Note

Low Risk
CI-only workflow wiring and inlined gates; no application runtime, auth, or data-path changes.

Overview
Restores the foundation CI gate by stopping use of the private wave-av/wave-foundation reusable workflow from this public repo, which caused runs to fail immediately with zero jobs.

Adds .github/workflows/_checks.yml as a local workflow_call mirror of wave-foundation checks@v1: secret scan (allowlist-aware), file-size gate (max_lines, default 800), optional *SKILL.md frontmatter validation, and optional wrangler.toml URL convention checks.

Updates foundation-gate.yml to call ./.github/workflows/_checks.yml via job id gate (preserving the gate / checks required-check naming) instead of wave-foundation/checks.yml@v1, with comments documenting the public/private constraint and the need to keep the vendored file in sync on v1 bumps.

Reviewed by Cursor Bugbot for commit 44e4128. Configure here.


Summary by cubic

Restores the foundation CI gate in this public repo by vendoring the reusable workflow and calling it locally. Fixes the 0-job GitHub Actions failure and re-enables required checks on PRs and pushes.

  • Bug Fixes
    • Added .github/workflows/_checks.yml mirroring wave-foundation/checks.yml@v1 (secret scan, file-size, SKILL.md validation, route naming checks); keep in sync with future v1 bumps.
    • Updated foundation-gate.yml to use the in-repo workflow via uses: ./.github/workflows/_checks.yml under job gate.
    • Preserves the required status check name "gate / checks" to satisfy branch protection.

Written for commit 44e4128. Summary will update on new commits.

Review in cubic

Root cause: foundation-gate.yml called the PRIVATE reusable
wave-av/wave-foundation/.github/workflows/checks.yml@v1 from this
PUBLIC repo. GitHub Actions does not permit a public repo to consume
a private repo's reusable workflow, so the run failed in 0s with 0
jobs on every PR/push.

Fix: vendor _checks.yml (mirrors wave-foundation checks.yml@v1) and
point foundation-gate.yml at it via `uses: ./.github/workflows/_checks.yml`
with job id `gate`, matching the known-good public-adopter pattern
(wave-moq-edge, dispatch-edge, adk, et al).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Jul 20, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 44e4128

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cursor

cursor Bot commented Jul 20, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_8dd87619-9e9a-4842-9cf7-5b04eead301c)

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 12 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 98626a7b-8b56-45d9-90be-d28823c141bb

📥 Commits

Reviewing files that changed from the base of the PR and between 90620e1 and 44e4128.

📒 Files selected for processing (2)
  • .github/workflows/_checks.yml
  • .github/workflows/foundation-gate.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/foundation-gate-public-template
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/foundation-gate-public-template

Comment @coderabbitai help to get the list of available commands.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: medium. Not approving: Cursor Bugbot skipped (usage limit reached) and did not complete automated review. Human review is needed for this CI workflow change; no reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@yakimoto
yakimoto merged commit cc66edc into main Jul 20, 2026
13 of 14 checks passed
@yakimoto
yakimoto deleted the fix/foundation-gate-public-template branch July 20, 2026 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant