Skip to content

ci(spec): fix oasdiff smoke test to use --version flag #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yakimoto wants to merge 1 commit into from
Closed

ci(spec): fix oasdiff smoke test to use --version flag #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/foundation-gate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,8 @@ jobs:
"https://github.com/oasdiff/oasdiff/releases/download/v1.28.0/checksums.txt"
(cd /tmp/oasdiff-install && grep "oasdiff_1.28.0_linux_amd64.tar.gz" checksums.txt | sha256sum -c -)
tar -xzf /tmp/oasdiff-install/oasdiff_1.28.0_linux_amd64.tar.gz -C /usr/local/bin
oasdiff version
# v1.28.0 has no `version` subcommand (exits 100); the flag form is correct.
oasdiff --version
Comment on lines +117 to +118

@devin-ai-integration devin-ai-integration Bot Aug 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Smoke-test flag form should be confirmed against the pinned oasdiff release

The only change swaps the smoke test from oasdiff version to oasdiff --version for the pinned v1.28.0 binary, with a comment asserting the subcommand form exits 100. Since the step runs under bash -e, a wrong flag form would fail the whole breaking-change job before the actual diff step; worth confirming the flag is supported by the exact pinned release (the comment is the only evidence in-repo). Note this step is purely a smoke test — dropping it entirely would also be an option if the CLI surface is unstable across versions.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

- name: Fail on unacknowledged breaking changes
# oasdiff breaking --fail-on ERR exits 1 when the PR's openapi.yaml has breaking
# changes vs the base branch (removed/renamed paths, removed required params, etc).
Expand Down
Loading