chore: adopt Apache-2.0 license + NOTICE - #6
Conversation
Standardize the open WAVE protocol/SDK surface on Apache-2.0 (patent grant for adoption). Replaces any prior license; adds NOTICE reserving the WAVE marks.
|
|
Warning Review limit reached
More reviews will be available in 4 minutes and 27 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
There was a problem hiding this comment.
1 issue found across 2 files
Confidence score: 4/5
- This PR is likely safe to merge with minimal technical risk; the reported issue is a documentation/legal metadata mismatch rather than a runtime bug.
- The main concern is in
LICENSEversusREADME:LICENSEstates Apache-2.0 while the README still states MIT, which can create user and compliance confusion if left unresolved. - Given the medium severity (5/10) and high confidence (8/10), this looks important to clean up soon but not likely to break functionality.
- Pay close attention to
LICENSE,README- align the declared license text to avoid downstream legal ambiguity.
You’re at about 91% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Architecture diagram
sequenceDiagram
participant Repo as Repository
Note over Repo: CHANGED: LICENSE replaced MIT with Apache-2.0
Note over Repo: NEW: NOTICE file added (trademark reservation)
Note over Repo: Impact: No runtime changes — static legal metadata only
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
…ublic spec Matches the repo's Apache-2.0 LICENSE file (was stale MIT in the info block). Removes the staging API host from the published server list (prod only).
Resolves cubic P2: LICENSE/NOTICE switched to Apache-2.0 but README still declared MIT. Make the declaration consistent. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…same-run pinned supplementary receipt Addresses the 27 open review threads on PR #93 without altering any previously measured output, status, SHA or command. Every addition is grounded in one anonymous live run at 2026-09-08T15:58:01Z whose /healthz reported commit ef1cf411b64e at both its start and end. API-001.md - Reproduction heading no longer calls every check "read-only": #4 sends an unpaid DELETE and the paywall-before-routing assumption is stated; a HEAD variant (402) is shown. - #2 keeps the grep and adds a strict JSON-parse form asserting error_detail.code is present and error is a string (not an object carrying .code). - #5 is narrowed to the declared Pagination envelope and explicitly does not claim to exercise concurrent writes; #5b sweeps every schema property and operation parameter for cursor-style names (NONE; only limit/offset in use). - #6 is scoped to gateway.wave.online/healthz; the header is read on three more public routes (constant on the two that emit it, absent on the two that do not). - The HTTP 401/402 trailer lines after bare `curl -sS` are explained as harness-appended and the literal `curl -w` form is shown with its output. - The private-repo revision comparison is labelled owner-only; /healthz is the public check. - Transcript fence gets a `text` language (MD040). PROTO-001.md - The three-dialect claim is now shown, not asserted: a second command keeps the response body, and crosscheck.py decodes the V1 JSON body, the V2 payment-required header and the MPP www-authenticate request= parameter from one response and compares amount/asset/payTo/network. - The V1/V2 field-name divergence (maxAmountRequired + network:base vs amount + eip155:8453) is documented and tied to the gateway's own public payments.json wire.v1/wire.v2 declaration, which is read back anonymously (norm.py) as the reproducible base -> eip155:8453 normalization. - The abridged www-authenticate transcript is annotated with the elided request=/expires=/ description= parameters so the amount row of the cross-check table is verifiable. - The 05:14Z receipt is marked unpinned (no same-run /healthz); the 15:58:01Z run is pinned. - Transcript fence gets a `text` language (MD040). Guard: public-repo-guard content policy OK; no private repo names, no on-chain addresses. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Standardizes this repo on Apache-2.0 (uniform across the WAVE open SDK/protocol surface; the patent grant matters for protocol adoption). Adds a NOTICE reserving the WAVE marks; sets
licensein package.json where present. License-only change — no code impact.Summary by cubic
Switches the repo to Apache-2.0 and adds a NOTICE reserving WAVE trademarks. Updates README and OpenAPI to Apache-2.0, removes the staging server from the public spec, and aligns with the WAVE SDK/protocol patent grant; no code changes.
Written for commit 6d23758. Summary will update on new commits.