chore(deps): update dependency @types/node to v26 - #26
Conversation
|
PR author is in the excluded authors list. |
| "@sentry/node": "^9.4.0", | ||
| "@types/inquirer": "^9.0.7", | ||
| "@types/node": "^22.13.0", | ||
| "@types/node": "^26.0.0", |
There was a problem hiding this comment.
🟡 Type definitions no longer match the oldest supported Node version
The project's Node type definitions are jumped to a major version that targets a much newer runtime ("@types/node": "^26.0.0" at package.json:74) while the project still declares support for Node 18 and up, so code can be type-checked as valid yet fail on the older runtimes users are told are supported.
Impact: Users on Node 18/20 may hit runtime errors from APIs that appear available during development.
Why the type-package major and the engines range must agree
package.json:49-51 declares "engines": { "node": ">=18.0.0" }, and tsconfig.json sets "types": ["node"]. DefinitelyTyped's @types/node majors track a specific Node major line; a v26 typings set describes APIs (and API-shape changes) present only in much newer Node, so builds silently permit usage unavailable on Node 18/20. Either keep the typings aligned with the minimum supported major, or raise the engines floor along with this bump.
Prompt for agents
package.json declares engines.node >= 18.0.0 but the devDependency @types/node was bumped to ^26.0.0, whose typings correspond to a much newer Node major. Since tsconfig.json includes "types": ["node"], type-checking will accept APIs that don't exist on Node 18/20. Decide whether to keep @types/node pinned to the major matching the minimum supported Node version, or to raise the engines floor (and document it in CHANGELOG.md as a user-facing change).
Was this helpful? React with 👍 or 👎 to provide feedback.
| "@sentry/node": "^9.4.0", | ||
| "@types/inquirer": "^9.0.7", | ||
| "@types/node": "^22.13.0", | ||
| "@types/node": "^26.0.0", |
There was a problem hiding this comment.
🟡 Changelog not updated for the dependency change
The repository's contributor rules require the Unreleased section of the changelog to be updated for user-facing changes, but this change ("@types/node": "^26.0.0" at package.json:74) leaves the Unreleased section empty, so the release notes don't reflect what changed.
Impact: Maintainers and users lose track of what shipped in the next release.
Rule reference
AGENTS.md states: "Conventional Commit titles; update CHANGELOG.md (Unreleased) for user-facing changes." CHANGELOG.md currently has an empty ## [Unreleased] section. If this dependency bump is considered non-user-facing, no entry is needed; but combined with the supported-Node implications it is worth an entry.
Was this helpful? React with 👍 or 👎 to provide feedback.
| "@sentry/node": "^9.4.0", | ||
| "@types/inquirer": "^9.0.7", | ||
| "@types/node": "^22.13.0", | ||
| "@types/node": "^26.0.0", |
There was a problem hiding this comment.
🔍 Only a typings devDependency changed; no runtime code affected
The diff touches only package.json:74 (@types/node bump). No source files, build config, or lockfile updates accompany it. tsconfig.json uses "types": ["node"] with skipLibCheck: true, so third-party typing breakage is mostly masked, but the repo's own code is still checked against the new typings — worth confirming npm run type-check and npm test pass on CI before merge, since major @types/node bumps frequently change signatures (e.g. Buffer, stream, and process APIs).
Was this helpful? React with 👍 or 👎 to provide feedback.
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This is a narrow, type-only dependency and lockfile update with no direct runtime source changes. Human review is still appropriate because both changed files are owned by the core team and an unresolved comment questions compatibility between the new typings and the supported Node versions. Not approved because:
Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more. |
753344e to
b97cbbd
Compare
|
Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI. |
b97cbbd to
3a66773
Compare
|
Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI. |
3a66773 to
1e253df
Compare
|
Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI. |
1e253df to
5ad3464
Compare
|
Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|


This PR contains the following updates:
^22.13.0→^26.0.0Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.