proxy-pom.xml: skip format-code plugin - #806
Conversation
|
This fix helps while building wavefront rpm from released source tarball, else we need to do git init after extracting the tagged tarball; since it's tagged code, is there any advantage in running format code on it? By released code I assume that code is already formatted. |
|
Hi, @prashant1221 and @sshedi Can you please ping me on slack ? |
|
Hi @laullon , can you please take these changes? |
|
LGTM, @sshedi can you add a note on the |
Sure, thanks. |
On released tag tarball 'mvn install' fails to execute format-code on project proxy because it expects the source to be git repository. Patch to Skip this with '-DskipFormatCode' while doing mvn install
|
@laullon I have made changes in the README.md, please review again. |
|
Thanks @laullon for your time and patience. |
On the released tags tarball 11.4 and 12.0,
mvn -f proxy clean install -DskipTestfails to execute format-code on project proxy because it expects the source to be git repository.Added the PR to skip this in proxy/pom.xml while doing mvn install.
mvn -f proxy clean install -DskipTests -DskipFormatCodeskips the format code for a released tarball.