Skip to content

proxy-pom.xml: skip format-code plugin - #806

Merged
laullon merged 2 commits into
wavefrontHQ:devfrom
prashant1221:master
Nov 2, 2022
Merged

proxy-pom.xml: skip format-code plugin#806
laullon merged 2 commits into
wavefrontHQ:devfrom
prashant1221:master

Conversation

@prashant1221

Copy link
Copy Markdown
Contributor

On the released tags tarball 11.4 and 12.0, mvn -f proxy clean install -DskipTest fails to execute format-code on project proxy because it expects the source to be git repository.

[ERROR] Failed to execute goal com.cosium.code:git-code-format-maven-plugin:3.3:format-code (format-code) on project proxy: Execution format-code of goal com.cosium.code:git-code-format-maven-plugin:3.3:format-code failed: One of setGitDir or setWorkTree must be called. -> [Help 1]

Added the PR to skip this in proxy/pom.xml while doing mvn install.
mvn -f proxy clean install -DskipTests -DskipFormatCode skips the format code for a released tarball.

@sshedi

sshedi commented Oct 26, 2022

Copy link
Copy Markdown

This fix helps while building wavefront rpm from released source tarball, else we need to do git init after extracting the tagged tarball; since it's tagged code, is there any advantage in running format code on it? By released code I assume that code is already formatted.

@laullon

laullon commented Oct 26, 2022

Copy link
Copy Markdown
Contributor

Hi, @prashant1221 and @sshedi Can you please ping me on slack ?

@laullon
laullon changed the base branch from master to dev October 26, 2022 11:08
@sshedi

sshedi commented Oct 28, 2022

Copy link
Copy Markdown

Hi @laullon , can you please take these changes?

@laullon

laullon commented Oct 28, 2022

Copy link
Copy Markdown
Contributor

LGTM, @sshedi can you add a note on the readme.md file about -DskipFormatCode, then I'll merge it to dev branch and master

@sshedi

sshedi commented Oct 28, 2022

Copy link
Copy Markdown

LGTM, @sshedi can you add a note on the readme.md file about -DskipFormatCode, then I'll merge it to dev branch and master

Sure, thanks.

On released tag tarball 'mvn install' fails to execute format-code
on project proxy because it expects the source to be git repository.
Patch to Skip this with '-DskipFormatCode' while doing mvn install
@prashant1221

Copy link
Copy Markdown
Contributor Author

@laullon I have made changes in the README.md, please review again.

@laullon
laullon self-requested a review November 2, 2022 10:37

@laullon laullon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laullon
laullon changed the base branch from dev to master November 2, 2022 10:38
@laullon
laullon changed the base branch from master to dev November 2, 2022 10:38
@laullon
laullon merged commit 1f9a237 into wavefrontHQ:dev Nov 2, 2022
laullon added a commit that referenced this pull request Nov 2, 2022
@sshedi

sshedi commented Nov 2, 2022

Copy link
Copy Markdown

Thanks @laullon for your time and patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants