MONIT 32316 process cloud watch logs - #827
Merged
Merged
Conversation
deosu
marked this pull request as ready for review
January 30, 2023 20:29
Contributor
Author
|
@laullon / @joannak-vmware please provide your review on this PR and help me in merging the changes with the dev branch. It is already reviewed by @xuranchen & is QA-certified. Here is a link to the Jira ticket - MONIT-32316 |
Contributor
|
We need first to release java-lib with your changes, the you can change the version pon the pom.xml, and then merge |
Contributor
|
LGTM, Will approve PR after pom file changes. |
joannatk
reviewed
Feb 14, 2023
# Conflicts: # proxy/pom.xml # proxy/src/main/java/com/wavefront/agent/listeners/WavefrontPortUnificationHandler.java
joannatk
approved these changes
Feb 18, 2023
joannatk
left a comment
Contributor
There was a problem hiding this comment.
LGTM, and java-lib updated
joannatk
added a commit
that referenced
this pull request
Mar 1, 2023
* Proxy V12.2 * Update wavefront.conf.default (#819) * Add 5 second timeout for PushAgent tests (#820) * MONIT-32454 Update Dockerfile to create a directory (#822) * Fix for CVE-2022-3171 (#825) * Add debug logging (#823) * MONIT-32483 record payloads batch before forwarding to vRLIC * MONIT-32483 surround logging with try-catch * prevent empty hostname tag * Fix for CVE-2022-41881 (7.5) (#833) * MONIT-30817: Api to get and search Proxy configuration (#832) * MONIT-30817: MONIT-30817: Api to get and search Proxy configuration #811 * MONIT-30818: MONIT-30818: Api to get and search pre processor rules #826 * Bump java-lib version to 2023-02.1 * MONIT 32316 process cloud watch logs (#827) * Update com.amazonaws - aws-java-sdk-sqs dep (#828) Co-authored-by: Joanna Ko <69543190+joannak-vmware@users.noreply.github.com> * MONIT-32317: Add a tag format to hyperlogs metrics (#831) --------- Co-authored-by: German Laullon <glaullon@vmware.com> Co-authored-by: Glenn Oppegard <goppegard@vmware.com> Co-authored-by: Sumit Deo <93740684+deosu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the proxy to read logs with a format(logs_json_cloudwatch).
This code change has a dependency on the next java-lib release(which should be released soon). If the latest java-lib release is not
2023-01.1, then we need to get java-lb changes locally from the feature branch and build the java-lib jar. Then build the proxy jar with the following command.mvn clean install:install-file -Dfile=<path to your java-lib jar> \ -DgroupId=com.wavefront \ -DartifactId=java-lib \ -Dversion=2023-01.1 \ -Dpackaging=jar