Reland "webnn: rename roundingType to outputShapeRounding for pool2d ops" - #60329
Merged
Merged
Conversation
chromium-wpt-export-bot
marked this pull request as ready for review
June 2, 2026 04:14
…ops"
This is a reland of commit e5811467122a07253805711cf7331c2de1741f1d.
The original CL was reverted because two newly-added baseline files
under platform/win11-arm64/virtual/webnn-service-on-cpu/... still
referenced the old "roundingType" test names, which no longer matched
the renamed WPT cases ("outputShapeRounding"). Those baselines are
updated in this reland.
Original change's description:
> webnn: rename roundingType to outputShapeRounding for pool2d ops
>
> This CL renames MLPool2dOptions::roundingType to
> MLPool2dOptions::outputShapeRounding in test files and implementations
> according to Spec change [1].
>
> [1] webmachinelearning/webnn#770
>
> Bug: 498118207
> Change-Id: I815c7f7728071144835c0ada0747bc9de2999669
> Cq-Include-Trybots: luci.chromium.try:mac14.arm64-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7717139
> Reviewed-by: Hu, Ningxin <ningxin.hu@intel.com>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Alex Gough <ajgo@chromium.org>
> Auto-Submit: Dai, Feng <feng.dai@intel.com>
> Commit-Queue: Dai, Feng <feng.dai@intel.com>
> Cr-Commit-Position: refs/heads/main@{#1618021}
Bug: 498118207
Change-Id: I4df2860081223af43493a0447ca5e69e104950df
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, win11-arm64-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7882018
Reviewed-by: Joe Mason <joenotcharles@google.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Hu, Ningxin <ningxin.hu@intel.com>
Commit-Queue: Dai, Feng <feng.dai@intel.com>
Reviewed-by: Elias Klim <elklm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1639919}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7882018
branch
from
June 2, 2026 04:14
fe16429 to
c130b67
Compare
wpt-pr-bot
approved these changes
Jun 2, 2026
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a reland of commit e5811467122a07253805711cf7331c2de1741f1d.
The original CL was reverted because two newly-added baseline files
under platform/win11-arm64/virtual/webnn-service-on-cpu/... still
referenced the old "roundingType" test names, which no longer matched
the renamed WPT cases ("outputShapeRounding"). Those baselines are
updated in this reland.
Original change's description:
Bug: 498118207
Change-Id: I4df2860081223af43493a0447ca5e69e104950df
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, win11-arm64-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7882018
Reviewed-by: Joe Mason <joenotcharles@google.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Hu, Ningxin <ningxin.hu@intel.com>
Commit-Queue: Dai, Feng <feng.dai@intel.com>
Reviewed-by: Elias Klim <elklm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1639919}