Skip to content

Pitch data constructor - #90

Merged
webern merged 5 commits into
masterfrom
pitch-data-constructor
May 10, 2020
Merged

Pitch data constructor#90
webern merged 5 commits into
masterfrom
pitch-data-constructor

Conversation

@webern

@webern webern commented May 8, 2020

Copy link
Copy Markdown
Owner

Closes #69

@webern

webern commented May 8, 2020

Copy link
Copy Markdown
Owner Author

There is something horrible about MSVC 19.25.28614.0 and I don't have time to chase it down. It's possible that there's undefined behavior in the mx code, but the last time I chased a Windows crash I ended up here: https://developercommunity.visualstudio.com/content/problem/847490/msvc-codegen-error-vector-reverse-iterator-x64-c17.html

The fix for mx was basically 'move something around so the buggy compiler doesn't make bad code'

#61 had the fix and it was here: https://github.com/webern/mx/blob/20796cd4638b8beec6f7833c436a7e267a5699c1/Sourcecode/private/mx/core/ElementInterface.cpp#L142...L150

@webern
webern merged commit bfe0408 into master May 10, 2020
@webern
webern deleted the pitch-data-constructor branch June 20, 2020 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] Constructor with defaults.

1 participant