Task refactor#716
Conversation
Co-authored-by: Shreyas Sharma <shreyassharma9912@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Ritesh Singh <133033102+riteshfyi@users.noreply.github.com> Co-authored-by: Vintha Vivekananda <151998489+vivekv1504@users.noreply.github.com> Co-authored-by: Bharath Balan <62698609+bhabalan@users.noreply.github.com> Co-authored-by: Kesava Krishnan Madavan <mkesavan13@gmail.com> Co-authored-by: Kesari3008 <65543166+Kesari3008@users.noreply.github.com> Co-authored-by: Matthew <matthew.olker@gmail.com> Co-authored-by: molker <molker@cisco.com> Co-authored-by: ciscoRankush <119413473+ciscoRankush@users.noreply.github.com> Co-authored-by: ciscoRankush <ciscoRankush@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Rankush Kumar <rankkuma+cisco@cisco.com> Co-authored-by: Govardhana vamshi <93788625+vamshigovardhana@users.noreply.github.com> Co-authored-by: CM <cmullenx@gmail.com> Co-authored-by: Christina Mullen <chrmulle@cisco.com> Co-authored-by: rsarika <95286093+rsarika@users.noreply.github.com> Co-authored-by: Zachary Raymer <zachraymer@gmail.com> Co-authored-by: Zach Raymer <zraymer@cisco.com> Co-authored-by: Akula Uday <akulakum@cisco.com>
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b7e8ea5b91
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| on: | ||
| push: | ||
| branches: # Allow list of deployable tags and branches. Note that all allow-listed branches cannot include any `/` characters | ||
| <<<<<<< next-in-task-refactor |
There was a problem hiding this comment.
The Deploy CD workflow now contains raw merge-conflict markers under on.push.branches. On pushes to next or task-refactor, GitHub Actions parses this YAML before any job runs, and these markers make the workflow invalid, so the release/tag/docs deploy path will not start. I also checked for other conflict markers with rg --hidden and only this workflow is affected.
Useful? React with 👍 / 👎.
| const wrapupCallCallback = () => { | ||
| try { | ||
| const wrapUpReason = store.wrapupCodes.find((code) => code.id === wrapUpAuxCodeId)?.name; | ||
| if (onWrapUp) { | ||
| onWrapUp({ | ||
| task: currentTask, | ||
| wrapUpReason: wrapUpReason, | ||
| }); | ||
| if (lastWrapupAuxCodeIdRef.current) { |
There was a problem hiding this comment.
When TASK_WRAPPEDUP is emitted without this component's wrapupCall() running first, such as auto-wrapup or wrap-up initiated from another widget/session, the SDK event still carries the selected wrapUpAuxCodeId, but this handler now ignores the event payload and exits while lastWrapupAuxCodeIdRef is null. That means the public onWrapUp callback never fires for those completed wrap-ups; keep accepting the event payload and only fall back to the ref when needed.
Useful? React with 👍 / 👎.
| const hasExistingLine = transcriptLines.some((line) => line.messageId === transcriptData.messageId); | ||
|
|
||
| this.store.realtimeTranscriptionData = hasExistingLine | ||
| ? transcriptLines.map((line) => | ||
| line.messageId === transcriptData.messageId ? {...line, ...newTranscriptData} : line |
There was a problem hiding this comment.
In multi-task sessions, realtime transcription listeners are registered for every task, but all events are merged into the singleton realtimeTranscriptionData and de-duped only by messageId. Because the new transcript widget later renders the whole singleton for whichever task is current, transcript lines from task B can appear while task A is selected, or overwrite task A's line if message IDs collide; include the interaction/conversation when storing and rendering these entries.
Useful? React with 👍 / 👎.
COMPLETES #< INSERT LINK TO ISSUE >
This pull request addresses
< DESCRIBE THE CONTEXT OF THE ISSUE >
by making the following changes
< DESCRIBE YOUR CHANGES >
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging
Make sure to have followed the contributing guidelines before submitting.