-
Notifications
You must be signed in to change notification settings - Fork 69
feat: refresh page and layout edits in place in dev #1405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
7f18870
feat: refresh page and layout edits in place in dev
vivek7405 6021479
test: browser coverage for the reload verdict relay and refreshPage
vivek7405 8baa77e
test: e2e proof that a dev page or layout edit never reloads
vivek7405 4b069c3
feat(gallery): demo refreshPage beside navigate and revalidate
vivek7405 57807f9
fix: read the refresh outcome, and re-request stylesheets after a swap
vivek7405 96b9c41
fix: keep the working stylesheet on a failed re-request, report applied
vivek7405 036a93d
fix: extract the stylesheet refresh so a browser test can drive it
vivek7405 ad48725
fix: force ok false on a superseded stream response
vivek7405 2fa8552
fix: complete the applied contract on loadFrame, and two doc slips
vivek7405 d2f80bd
fix: keep classifying after a rebuild, and stop claiming an uncommitt…
vivek7405 8b786c8
fix: report the uncommitted swap without changing the pipeline
vivek7405 bf18d84
test: cover the applied flag on the paths that commit nothing
vivek7405 b3b9868
test: make the URL-advance case observe its own click
vivek7405 364133f
test: move the URL parking inside the case's try block
vivek7405 31dd537
test: assert the history call instead of dancing the URL around
vivek7405 11302ab
fix: dismiss a live error overlay before an in-place refresh
vivek7405 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.