-
Notifications
You must be signed in to change notification settings - Fork 69
fix: render error boundaries inside their layout chain #1413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4ee36d4
fix: render error boundaries inside their layout chain
vivek7405 5760cc3
test: prove a nav into a throwing page is a soft navigation
vivek7405 bf00e9a
test: raise the ssr barrel floor for the two boundary helpers
vivek7405 870d45e
test: narrow the error-boot assertion to what actually rendered
vivek7405 170310a
fix: never advertise a layout region the boundary did not render
vivek7405 f9b062c
chore: drop verification scratch apps swept in by git add -A
vivek7405 fc2fce3
fix: close three gaps opened by shipping the boundary boot set
vivek7405 7b26242
fix: do not report a control-flow throw as a crash, and stop losing t…
vivek7405 05991db
fix: report a boundary-path failure once, and never over the root cause
vivek7405 f72c16d
fix: dedupe boundary reports by cause, not by "one per request"
vivek7405 e2ac6d9
fix: key boundary-report dedup on the stage, and make the key total
vivek7405 7b24eec
fix: stop a boundary crash leaking its message, and formatting one fr…
vivek7405 1fe89dc
test: assert the 404 fallback body is dev-only
vivek7405 3afb2d7
fix: report a boundary module that throws or fails to load
vivek7405 0af5cf8
fix: report a boundary tree failure once, and wire the unrouted 404 s…
vivek7405 c0c978c
fix: record the boundary failure phase instead of inferring it
vivek7405 641dca1
fix: diagnose a boundary failure by the fallback, not the marker alone
vivek7405 fdf0e4c
fix: do not treat a failed prefetch as a recovery, or re-render a cha…
vivek7405 0ca2e52
fix: make the tree-failure fixtures runtime-agnostic, and skip a poin…
vivek7405 f6cf4a5
fix: wrap the DEFAULT boundary page, and use nearest-wins on the form…
vivek7405 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.