Repository navigation
Fix concurrency, detached document, and permissions checks in algorithms. - #337
markafoltz wants to merge 2 commits into
Conversation
| [=iteration/continue=]. | ||
|
|
||
| 1. [=list/Append=] (|tool definition|, |targetDocument|, |targetOrigin|) to | ||
| |discoveredTools|. |
There was a problem hiding this comment.
I think we can omit |targetOrigin| since that's already captured by |targetDocument|'s [=Document/origin=] right?
There was a problem hiding this comment.
I wonder if |targetOrigin| can change between the capture here and the task below that iterates over |discoveredTools|.
|
|
||
| 1. Let |document| be |descendant|'s [=navigable/active document=]. | ||
|
|
||
| 1. If |document| is not [=allowed to use=] the "{{tools}}" feature, then |
There was a problem hiding this comment.
Hmm, I suppose this isn't strictly necessary since a document without this feature cannot even populate tools in its internal context's tool map accessed below, right?
I guess it's good documentation for an agent though. Does my assessment above match your understanding?
There was a problem hiding this comment.
The perform and observation algorithm can be triggered at any time. If the spec can guarantee that the tool map is always synchronized with the state of the tools permission, then this can be skipped. But it's also fine to leave in as documentation. Let me know what you think.
toolspermission.RegisteredTools, asparse a JSON stringcannot happen in parallel.Preview | Diff