Repository navigation
Replace UnknownError with specific DOMException types. - #339
Open
markafoltz wants to merge 1 commit into
Open
markafoltz wants to merge 1 commit into
markafoltz wants to merge 1 commit into
Conversation
markafoltz
commented
Oct 7, 2026
| 1. [=map/Remove=] |localExecutions|[|uuid|]. | ||
|
|
||
| 1. Run |completionSteps| given null and false. | ||
| 1. Run |completionSteps| given null and "{{OperationError}}". |
Collaborator
Author
There was a problem hiding this comment.
This quashes all tool promise rejections into OperationError, even if executeTool() is called on a same-document registered tool. I could see an argument for propagating the full rejection object in that case, but it would make the behavior less consistent.
markafoltz
requested review from
bwalderman and
domfarolino
and removed request for
domfarolino
October 7, 2026 17:07
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #323.
Preview | Diff