fix(sqlite): enforce foreign key constraints on connect - #66
Merged
Conversation
SQLite ignores FOREIGN KEY constraints unless a connection issues PRAGMA foreign_keys = ON; this library never did, so FK violations were silently accepted on SQLite regardless of schema definitions. Fix: enable the pragma in Connection::createPdo() for every SQLite connection. Also drops the SQLite skip in SchemaForeignKeyTest::testCreateWithForeignKeyActuallyEnforcesTheConstraint, now that it passes on all drivers. Adds tests/Integration/SqliteForeignKeyPragmaTest.php; reproduced against the pre-fix code (pragma read back as 0, orphan inserts succeeded) and verified fixed. Full unit + integration suites pass on both MySQL and SQLite with no regressions. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLite ignores FOREIGN KEY constraints unless a connection issues PRAGMA foreign_keys = ON; this library never did, so FK violations were silently accepted on SQLite regardless of schema definitions.
Fix: enable the pragma in Connection::createPdo() for every SQLite connection. Also drops the SQLite skip in
SchemaForeignKeyTest::testCreateWithForeignKeyActuallyEnforcesTheConstraint, now that it passes on all drivers.
Adds tests/Integration/SqliteForeignKeyPragmaTest.php; reproduced against the pre-fix code (pragma read back as 0, orphan inserts succeeded) and verified fixed. Full unit + integration suites pass on both MySQL and SQLite with no regressions.