Skip to content

Added support for OpenSSL >= 1.1.0. - #43

Merged
wernerd merged 1 commit into
wernerd:masterfrom
welljsjs:master
Aug 27, 2019
Merged

Added support for OpenSSL >= 1.1.0.#43
wernerd merged 1 commit into
wernerd:masterfrom
welljsjs:master

Conversation

@welljsjs

@welljsjs welljsjs commented Aug 26, 2019

Copy link
Copy Markdown
Contributor

In openssl v1.1.0, lots of structures were hidden and one now has to communicate with API through opaque pointers.

https://wiki.openssl.org/index.php/OpenSSL_1.1.0_Changes

This PR adds support for openssl versions >=1.1.0. However, it does still support versions below.

@wernerd

wernerd commented Aug 27, 2019

Copy link
Copy Markdown
Owner

Hi there,
thanks for the patch to support OpenSSL 1.1.0 and above. Much appreciated :-) .

Werner

@wernerd
wernerd merged commit ca5becb into wernerd:master Aug 27, 2019
@welljsjs

Copy link
Copy Markdown
Contributor Author

Sure, no problem. Did you have time to review it though? Just to make sure because I'm not too familiar with the API (although that's rather a minor change and I don't think I messed up things completely..) 😁

@wernerd

wernerd commented Aug 28, 2019

Copy link
Copy Markdown
Owner

Yes, I reviewed the changes and saw no real issue, however not tested it yet. I leave that for the weekend when I have some more time.

Comment thread srtp/crypto/openssl/hmac.cpp
Comment thread srtp/crypto/openssl/hmac.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants