Link exercises in the routine detail view to their detail page - #1318
Open
faithless11 wants to merge 1 commit into
Open
faithless11 wants to merge 1 commit into
faithless11 wants to merge 1 commit into
Conversation
The exercise names in the routine overview (and the dashboard routine card, which reuses SetConfigDataDetails) are now links to the exercise detail page, so users can look up how an exercise is performed directly from their plan. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
RoutineDetailsCard: bothSetConfigDataDetailsfor days with sequence data andSlotEntryListfor days without) are now links to the exercise detail page. The link is built withmakeLink(WgerLink.EXERCISE_DETAIL, …)including the slug, like in the exercise overview.SetConfigDataDetails, the exercises are linked there as well.color="inherit"andunderline="hover", so the view looks the same as before until you hover over a name.Related Issue(s)
Closes #1317
Please check that the PR fulfills these requirements
Ran locally:
vitest run src/components/Routines src/components/Dashboard(51 files, 304 tests passing),tsc --noEmitandeslinton the changed files.