Skip to content

Feature/wb7 adc fixup - #96

Merged
vdromanov merged 3 commits into
dev/v5.10.yfrom
feature/wb7-adc-fixup
Jun 17, 2022
Merged

Feature/wb7 adc fixup#96
vdromanov merged 3 commits into
dev/v5.10.yfrom
feature/wb7-adc-fixup

Conversation

@vdromanov

@vdromanov vdromanov commented Jun 15, 2022

Copy link
Copy Markdown
Contributor

На всех wb7 присутствует проблема с adc. Для пользователя выглядит, как "периодические странные показания, когда к каналу не подключено ничего".
Экспериментально выяснено:

  1. проблема точно программная (осцилл ничего не видит)
  2. проблема на уровне ядра
  3. основная гипотеза - adc успевает что-то намерить до того, как выбирается канал. Подтверждается экспериментально (см картинки; на них a1-a3, vin; поллятся раз в 0.5с). => видим измерения с другого канала

до фикса (a1-a3 пустые):
2022-06-09_09-15-43

проверка гипотезы про fifo: отпаял vin; тем не менее видим на нем показания. Подключено: 0, 3v3, 5v, vin (разорвал)
2022-06-15_11-15-03

info->data->tp_adc_select |
info->data->adc_chan_select(channel));
/*
* When the IP changes channel, it needs a bit of time to get

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

по-моему, ноги из fifo растут

@evgeny-boger evgeny-boger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а смотрел кстати реализацию в родном драйвере олвиннера? Они это делают?

@vdromanov

vdromanov commented Jun 16, 2022

Copy link
Copy Markdown
Contributor Author

у олвиннера нашел 2 реализации:

@vdromanov

Copy link
Copy Markdown
Contributor Author

@ExplorerOL попробовал - у него тоже починилось
было - стало
2022-06-17_10-47-22
2022-06-17_10-47-29

думаю, можно вливать

@vdromanov
vdromanov merged commit 95b3eb5 into dev/v5.10.y Jun 17, 2022
@vdromanov
vdromanov deleted the feature/wb7-adc-fixup branch June 17, 2022 10:52
evgeny-boger pushed a commit that referenced this pull request Aug 3, 2022
* sun4i-gpadc: flushing adc fifo after channel has set up

* sun4i-gpadc: removed "waiting for correct values after adc channel changed"

* bumped version
evgeny-boger pushed a commit that referenced this pull request Mar 26, 2024
* sun4i-gpadc: flushing adc fifo after channel has set up

* sun4i-gpadc: removed "waiting for correct values after adc channel changed"

* bumped version
taraant pushed a commit that referenced this pull request May 16, 2025
* sun4i-gpadc: flushing adc fifo after channel has set up

* sun4i-gpadc: removed "waiting for correct values after adc channel changed"

* bumped version
taraant pushed a commit that referenced this pull request May 16, 2025
Original commits:
  drivers/iio/adc/Kconfig
    e0e8cf4: iio:adc: add WBEC ADC driver
  drivers/iio/adc/Makefile
    e0e8cf4: iio:adc: add WBEC ADC driver
  drivers/iio/adc/adc-wbec.c
    e0e8cf4: iio:adc: add WBEC ADC driver
  drivers/iio/adc/axp20x_adc.c
    af21015: iio: adc: axp20x_adc: fix charging current reporting on AXP22x
    6b2eb49: iio:ad:axp20x: add support for NTC thermistor
  drivers/iio/adc/sun4i-gpadc-iio.c
    26fd41b: iio: adc: sun4i-gpadc-iio: no temp sensor on R40 (submitted to upstream)
    eba9a32: mfd: sun4i-gpadc: add of_compatible for child iio driver
    be53fc6: iio: adc: sun4i-gpadc-iio: replace delay with sleep
    95b3eb5: Feature/wb7 adc fixup (#96)
taraant pushed a commit that referenced this pull request May 20, 2025
* sun4i-gpadc: flushing adc fifo after channel has set up

* sun4i-gpadc: removed "waiting for correct values after adc channel changed"

* bumped version
taraant pushed a commit that referenced this pull request May 20, 2025
Original commits:
  drivers/iio/adc/Kconfig
    e0e8cf4: iio:adc: add WBEC ADC driver
  drivers/iio/adc/Makefile
    e0e8cf4: iio:adc: add WBEC ADC driver
  drivers/iio/adc/adc-wbec.c
    e0e8cf4: iio:adc: add WBEC ADC driver
  drivers/iio/adc/axp20x_adc.c
    af21015: iio: adc: axp20x_adc: fix charging current reporting on AXP22x
    6b2eb49: iio:ad:axp20x: add support for NTC thermistor
  drivers/iio/adc/sun4i-gpadc-iio.c
    26fd41b: iio: adc: sun4i-gpadc-iio: no temp sensor on R40 (submitted to upstream)
    eba9a32: mfd: sun4i-gpadc: add of_compatible for child iio driver
    be53fc6: iio: adc: sun4i-gpadc-iio: replace delay with sleep
    95b3eb5: Feature/wb7 adc fixup (#96)
taraant pushed a commit that referenced this pull request Jun 9, 2025
* sun4i-gpadc: flushing adc fifo after channel has set up

* sun4i-gpadc: removed "waiting for correct values after adc channel changed"

* bumped version
taraant pushed a commit that referenced this pull request Jul 29, 2025
* sun4i-gpadc: flushing adc fifo after channel has set up

* sun4i-gpadc: removed "waiting for correct values after adc channel changed"

* bumped version
taraant pushed a commit that referenced this pull request Oct 31, 2025
* sun4i-gpadc: flushing adc fifo after channel has set up

* sun4i-gpadc: removed "waiting for correct values after adc channel changed"

* bumped version
taraant pushed a commit that referenced this pull request Apr 14, 2026
* sun4i-gpadc: flushing adc fifo after channel has set up

* sun4i-gpadc: removed "waiting for correct values after adc channel changed"

* bumped version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants