Skip to content

Add Statement::newFromMainSnak #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JeroenDeDauw wants to merge 1 commit into from
Closed

Add Statement::newFromMainSnak #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/Statement/Statement.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,17 @@ public function __construct( Claim $claim, ReferenceList $references = null ) {
$this->references = $references === null ? new ReferenceList() : $references;
}

/**
* @since 2.2
*
* @param Snak $mainSnak
*
* @return Statement
*/
public static function newFromMainSnak( Snak $mainSnak ) {

@thiemowmde thiemowmde Nov 3, 2014

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional $qualifiers and $references are missing. Which is what my #268 does, by the way.

@JeroenDeDauw JeroenDeDauw Nov 3, 2014

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method is for constructing a new instance from a main snak. Not other stuff as well.

@thiemowmde thiemowmde Nov 4, 2014

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we will also add newFromMainSnakAndQualifiers as well as newFromMainSnakQualifiersAndReferences? That's what optional parameters are for. That's what constructors are for. Introducing more of these static method(s) means we will replace all new Statement( ... ) calls with static Statement::new...( ... ). I don't see how this makes the overall situation better.

return new self( new Claim( $mainSnak ) );
}

/**
* Returns the references attached to this statement.
*
Expand Down
7 changes: 7 additions & 0 deletions tests/unit/Statement/StatementTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,4 +367,11 @@ public function testGetClaim() {
$this->assertSame( $qualifiers, $claim->getQualifiers() );
}

public function testNewFromMainSnak() {
$snak = new PropertyNoValueSnak( new PropertyId( 'P42' ) );

$statement = Statement::newFromMainSnak( $snak );
$this->assertEquals( $snak, $statement->getMainSnak() );
}

}