Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions src/Entity/Property.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
namespace Wikibase\DataModel\Entity;

use InvalidArgumentException;
use Wikibase\DataModel\Claim\Claim;
use Wikibase\DataModel\Claim\Claims;
use Wikibase\DataModel\Snak\Snak;
use Wikibase\DataModel\Statement\Statement;
use Wikibase\DataModel\Statement\StatementList;
use Wikibase\DataModel\Term\Fingerprint;
use Wikibase\DataModel\StatementListProvider;
Expand Down Expand Up @@ -203,4 +207,59 @@ public function setStatements( StatementList $statements ) {
$this->statements = $statements;
}

/**
* @deprecated since 1.0, use getStatements instead
*
* @return Statement[]
*/
public function getClaims() {
return $this->statements->toArray();
}

/**
* @deprecated since 1.0, use setStatements instead
*
* @param Claims $claims
*/
public function setClaims( Claims $claims ) {
$this->statements = new StatementList( iterator_to_array( $claims ) );
}

/**
* @deprecated since 1.0, use getStatements instead
*
* @return bool
*/
public function hasClaims() {
return !$this->statements->isEmpty();
}

/**
* @deprecated since 1.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use what instead?

*
* @param Snak $mainSnak
*
* @return Statement
*/
public function newClaim( Snak $mainSnak ) {
return new Statement( new Claim( $mainSnak ) );
}

/**
* @deprecated since 1.0, use getStatements instead
*
* @param Claim $statement This needs to be a Statement as of 1.0
*
* @throws InvalidArgumentException
*/
public function addClaim( Claim $statement ) {
if ( !( $statement instanceof Statement ) ) {
throw new InvalidArgumentException( '$statement must be an instance of Statement' );
} elseif ( $statement->getGuid() === null ) {
throw new InvalidArgumentException( 'Can\'t add a Claim without a GUID.' );
}

$this->statements->addStatement( $statement );
}

}
32 changes: 32 additions & 0 deletions tests/unit/Entity/PropertyTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
use Wikibase\DataModel\Entity\PropertyId;
use Wikibase\DataModel\Snak\PropertyNoValueSnak;
use Wikibase\DataModel\Statement\StatementList;
use Wikibase\DataModel\Statement\Statement;
use Wikibase\DataModel\Snak\PropertySomeValueSnak;
use Wikibase\DataModel\Claim\Claims;

/**
* @covers Wikibase\DataModel\Entity\Property
Expand Down Expand Up @@ -207,4 +210,33 @@ public function testPropertyWithStatementsIsNotEmpty() {
$this->assertFalse( $property->isEmpty() );
}

public function testNewClaimReturnsStatementWithProvidedMainSnak() {
/** @var Snak $snak */
$snak = $this->getMock( 'Wikibase\DataModel\Snak\Snak' );

$property = Property::newFromType( 'string' );
$statement = $property->newClaim( $snak );

$this->assertInstanceOf( 'Wikibase\DataModel\Statement\Statement', $statement );
$this->assertEquals( $snak, $statement->getMainSnak() );
}

public function testSetClaims() {
$property = Property::newFromType( 'string' );

$statement0 = new Statement( new Claim( new PropertyNoValueSnak( 42 ) ) );
$statement0->setGuid( 'TEST$NVS42' );

$statement1 = new Statement( new Claim( new PropertySomeValueSnak( 42 ) ) );
$statement1->setGuid( 'TEST$SVS42' );

$statements = array( $statement0, $statement1 );

$property->setClaims( new Claims( $statements ) );
$this->assertEquals( count( $statements ), $property->getStatements()->count(), "added some statements" );

$property->setClaims( new Claims() );
$this->assertTrue( $property->getStatements()->isEmpty(), "should be empty again" );
}

}