Skip to content

Favor StatementList's argument list constructor #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thiemowmde wants to merge 1 commit into from
Closed

Favor StatementList's argument list constructor #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/unit/Entity/Diff/EntityDiffTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public function diffProvider() {

$statementListDiffer = new StatementListDiffer();
$diffOps['claim'] = $statementListDiffer->getDiff(
new StatementList( array( $statement ) ),
new StatementList( $statement ),
new StatementList()
);

Expand Down
2 changes: 1 addition & 1 deletion tests/unit/Entity/ItemTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ public function testCanConstructWithStatementList() {
$statement = new Statement( new Claim( new PropertyNoValueSnak( 42 ) ) );
$statement->setGuid( 'meh' );

$statements = new StatementList( array( $statement ) );
$statements = new StatementList( $statement );

$item = new Item( null, null, null, $statements );

Expand Down
42 changes: 21 additions & 21 deletions tests/unit/Statement/StatementListDifferTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ private function assertResultsInDiff( StatementList $fromStatements, StatementLi
}

public function testGivenTwoIdenticalLists_diffIsEmpty() {
$statements = new StatementList( array(
$statements = new StatementList(
$this->getNewStatement( 'zero', 'first' ),
$this->getNewStatement( 'one', 'second' ),
) );
$this->getNewStatement( 'one', 'second' )
);

$this->assertResultsInDiff( $statements, $statements, new Diff() );
}
Expand All @@ -49,16 +49,16 @@ private function getNewStatement( $guid, $hash ) {
}

public function testGivenToListWithExtraStatement_additionOperationInDiff() {
$fromStatements = new StatementList( array(
$fromStatements = new StatementList(
$this->getNewStatement( 'zero', 'first' ),
$this->getNewStatement( 'one', 'second' ),
) );
$this->getNewStatement( 'one', 'second' )
);

$toStatements = new StatementList( array(
$toStatements = new StatementList(
$this->getNewStatement( 'zero', 'first' ),
$this->getNewStatement( 'two', 'third' ),
$this->getNewStatement( 'one', 'second' ),
) );
$this->getNewStatement( 'one', 'second' )
);

$diff = new Diff( array(
'two' => new DiffOpAdd( $this->getNewStatement( 'two', 'third' ) ),
Expand All @@ -68,15 +68,15 @@ public function testGivenToListWithExtraStatement_additionOperationInDiff() {
}

public function testGivenToListWithLessStatements_removalOperationsInDiff() {
$fromStatements = new StatementList( array(
$fromStatements = new StatementList(
$this->getNewStatement( 'zero', 'first' ),
$this->getNewStatement( 'one', 'second' ),
$this->getNewStatement( 'two', 'third' ),
) );
$this->getNewStatement( 'two', 'third' )
);

$toStatements = new StatementList( array(
$this->getNewStatement( 'one', 'second' ),
) );
$toStatements = new StatementList(
$this->getNewStatement( 'one', 'second' )
);

$diff = new Diff( array(
'zero' => new DiffOpRemove( $this->getNewStatement( 'zero', 'first' ) ),
Expand All @@ -87,17 +87,17 @@ public function testGivenToListWithLessStatements_removalOperationsInDiff() {
}

public function testGivenListWithChangedStatements_changeOperationsInDiff() {
$fromStatements = new StatementList( array(
$fromStatements = new StatementList(
$this->getNewStatement( 'zero', 'first' ),
$this->getNewStatement( 'one', 'second' ),
$this->getNewStatement( 'two', 'third' ),
) );
$this->getNewStatement( 'two', 'third' )
);

$toStatements = new StatementList( array(
$toStatements = new StatementList(
$this->getNewStatement( 'zero', 'FIRST' ),
$this->getNewStatement( 'one', 'second' ),
$this->getNewStatement( 'two', 'THIRD' ),
) );
$this->getNewStatement( 'two', 'THIRD' )
);

$diff = new Diff( array(
'zero' => new DiffOpChange(
Expand Down
Loading