Minor wolfguard impl. improvements - #147
Open
gasbytes wants to merge 1 commit into
Open
Conversation
gasbytes
commented
Aug 4, 2026
Contributor
- various minor fixes to formatting and comments
- mtu boundary test (1-byte payload sweep across the wg0 mtu);
- replay-window advance test (sustain properly a flood of 2000 packets);
- wg_timers.c refactor of the tick function into separate modules
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes small wolfGuard implementation cleanups, adds additional loopback coverage around MTU boundaries and replay-window behavior, and refactors the WireGuard timer tick logic for readability/maintainability.
Changes:
- Refactors
wg_timers_tick()into focused helper functions for each timer rule. - Adds two new loopback integration tests: an MTU boundary sweep and a sustained flood to exercise replay-window advancement.
- Cleans up comments/formatting across multiple wolfGuard source files and removes the
bench-wolfguardMakefile target rules.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/wolfguard/wolfguard.h | Minor comment/formatting cleanup in keypair storage. |
| src/wolfguard/wolfguard.c | Moves/cleans up comments around wolfguard_ll_send() and nearby formatting. |
| src/wolfguard/wg_timers.c | Refactors timer tick logic into helper functions; adds clarifying comments. |
| src/wolfguard/wg_packet.c | Comment updates/cleanup; minor formatting around TX path comments. |
| src/wolfguard/wg_noise.c | Comment cleanup and clarification about PSK aliasing during handshake init. |
| src/wolfguard/wg_cookie.c | Comment whitespace cleanup. |
| src/wolfguard/wg_allowedips.c | Comment whitespace cleanup. |
| src/test/test_wolfguard_loopback.c | Adds MTU sweep and sustained flood tests; extends suite assembly accordingly. |
| Makefile | Removes bench-wolfguard build rules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gasbytes
force-pushed
the
wolfguard-fixes-and-improvements
branch
2 times, most recently
from
August 4, 2026 15:45
e5a415e to
a939fe9
Compare
gasbytes
marked this pull request as ready for review
August 6, 2026 10:33
- various minor fixes to formatting and comments - mtu boundary test (1-byte payload sweep across the wg0 mtu); - replay-window advance test (sustain properly a flood of 2000 packets); - wg_timers.c refactor of the tick function into separate modules
gasbytes
force-pushed
the
wolfguard-fixes-and-improvements
branch
from
August 6, 2026 10:34
a939fe9 to
25e3f5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.